-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow any protocol for cors origins #11153
Allow any protocol for cors origins #11153
Conversation
Welcome @iterion! |
Hi @iterion. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a2d800c
to
f7e3e8c
Compare
f7e3e8c
to
4324382
Compare
/ok-to-test @iterion can you check on the golint error and/or add an ignore statement |
Done! I noticed elsewhere |
This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach |
The This bot removes
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /remove-lifecycle frozen |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iterion, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Some applications which wrap browsers (like Tauri) use an origin such as
tauri://localhost
. Since the ingress-nginx regex only allows http[s] that means we can't easily enable cors for our tauri app.This PR broadens the regex for the origin to allow any protocol. From my read, the regex that is generated for the nginx config should still correctly work with any protocol.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
I've updated the tests to cover a case I'd like to see, and I'll be doing further testing in our environment soon.
Update: we've deployed this to production and it's been working as expected for us and fixes our Tauri cors issues.
Checklist: