Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in OTel doc #11129

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Fix typos in OTel doc #11129

merged 1 commit into from
Mar 14, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Mar 14, 2024

Original PR: #11081

Automated cherry-pick was failing, dunno why, so I did it manually.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 14, 2024
@Gacko
Copy link
Member Author

Gacko commented Mar 14, 2024

/cc @longwuyuan @strongjz

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2024
@Gacko
Copy link
Member Author

Gacko commented Mar 14, 2024

/triage accepted
/kind documentation
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/documentation Categorizes issue or PR as related to documentation. area/docs labels Mar 14, 2024
@k8s-ci-robot k8s-ci-robot requested review from cpanato and puerco March 14, 2024 15:12
@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Mar 14, 2024
@longwuyuan
Copy link
Contributor

/assign @esigo

@Gacko
Copy link
Member Author

Gacko commented Mar 14, 2024

@longwuyuan This is a cherry-pick from main, it already has been merged there.

@longwuyuan
Copy link
Contributor

@longwuyuan This is a cherry-pick from main, it already has been merged there.

ah ok.

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, longwuyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4f53022 into kubernetes:release-1.10 Mar 14, 2024
3 checks passed
@Gacko Gacko deleted the ujoni branch March 14, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longwuyuan longwuyuan Awaiting requested review from longwuyuan

@strongjz strongjz Awaiting requested review from strongjz

@cpanato cpanato Awaiting requested review from cpanato

@puerco puerco Awaiting requested review from puerco

Assignees

@longwuyuan longwuyuan

@esigo esigo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gacko @longwuyuan @k8s-ci-robot @esigo @Hexcles