Chart: Align HPA & KEDA conditions.

[Gacko]

What this PR does / why we need it:

Aligns how we are respecting controller.autoscaling.enabled and controller.keda.enabled across the chart.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

Fixes #10814.

How Has This Been Tested?

Added unit tests.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	37e8199
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65f02fbc57166a00081986ac

[Gacko]

/assign
/triage accepted
/kind bug
/priority backlog
/cherry-pick release-1.10

[k8s-infra-cherrypick-robot]

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/assign
/triage accepted
/kind bug
/priority backlog
/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Gacko]

cc @StuxxNet @rikatz @cpanato for review. 🙂

[strongjz]

should we cherry pick bug fixes for 1.9 as well

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [Gacko,strongjz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

Probably yes, but that might be difficult as release-1.9 is quite different to current main in many ways.

[k8s-infra-cherrypick-robot]

@Gacko: new pull request created: #11113

In response to this:

/assign
/triage accepted
/kind bug
/priority backlog
/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.