feature(geoip2_autoreload): Enable GeoIP2 auto_reload config

[msfidelis]

What this PR does / why we need it:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

fixes #8784

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Hi @msfidelis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	ab2f4a1
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65f76f38c4ebc000083f88ea

[msfidelis]

I need more time to study geoip2 and MaxMind databases. I will open the PR for help and community suggestions.

[rikatz]

/ok-to-test

[strongjz]

@msfidelis please review the panics in the e2e tests.

/assign @strongjz
/priority backlog
/triage accepted
/kind feature

[strongjz]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msfidelis, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [strongjz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kd7lxl]

I am curious what the impetus to add this was. There is already an event-driven reload here:

ingress-nginx/internal/ingress/controller/nginx.go

Lines 183 to 215 in 48fbdfe

	filesToWatch := []string{}
	if err := os.Mkdir("/etc/ingress-controller/geoip/", 0o755); err != nil && !os.IsExist(err) {
	klog.Fatalf("Error creating geoip dir: %v", err)
	}
	err = filepath.WalkDir("/etc/ingress-controller/geoip/", func(path string, info fs.DirEntry, err error) error {
	if err != nil {
	return err
	}
	if info.IsDir() {
	return nil
	}
	filesToWatch = append(filesToWatch, path)
	return nil
	})
	if err != nil {
	klog.Fatalf("Error creating file watchers: %v", err)
	}
	for _, f := range filesToWatch {
	// This redeclaration is necessary for the closure to get the correct value for the iteration in go versions <1.22
	// See https://go.dev/blog/loopvar-preview
	f := f
	_, err = file.NewFileWatcher(f, func() {
	klog.InfoS("File change detected. Reloading NGINX", "path", f)
	n.syncQueue.EnqueueTask(task.GetDummyObject("file-change"))
	})
	if err != nil {
	klog.Fatalf("Error creating file watcher for %v: %v", f, err)
	}
	}

In some installations, I've found the file-change detection isn't reloading the geoip db in nginx. Curious if you also encountered that and that's why you added the new config. We probably need to fix or remove the event-driven approach if I'm not the only one with the problem.