Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate third party NGINX configuration #10470

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Separate third party NGINX configuration #10470

merged 2 commits into from
Nov 3, 2023

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Oct 1, 2023

As a initial step to separate controller from NGINX process, we need to make sure that directories that will be written by controller are well defined and will not conflict with pre-existing files from NGINX process.

This way, this PR separates some basic files (GeoIP, tickets.key) from /etc/nginx directory

@netlify
Copy link

netlify bot commented Oct 1, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit f6f1614
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/654430bdee5fdb00085b1729

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 1, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2023
@k8s-ci-robot k8s-ci-robot requested a review from strongjz October 1, 2023 22:15
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2023
@rikatz rikatz force-pushed the separate-for-real branch from 02561ac to 8754cbe Compare October 15, 2023 22:38
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2023
@rikatz rikatz force-pushed the separate-for-real branch 3 times, most recently from 34f96ab to e75b7b6 Compare October 22, 2023 20:48
@rikatz rikatz force-pushed the separate-for-real branch from e75b7b6 to 906d3cb Compare November 2, 2023 20:22
@rikatz rikatz force-pushed the separate-for-real branch 2 times, most recently from 4aadaa7 to f43c40f Compare November 2, 2023 22:33
@rikatz rikatz force-pushed the separate-for-real branch from f43c40f to f6f1614 Compare November 2, 2023 23:28
@tao12345666333
Copy link
Member

/assign

tao12345666333
tao12345666333 reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left one question

rootfs/chroot.sh Show resolved Hide resolved
@rikatz
Copy link
Contributor Author

rikatz commented Nov 3, 2023

chroot and mirror test were failing due to it 🤷‍♂️

@strongjz
Copy link
Member

strongjz commented Nov 3, 2023

Let's go!!!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9ed0d7f into kubernetes:main Nov 3, 2023
38 checks passed
@strongjz strongjz deleted the separate-for-real branch November 3, 2023 13:51
@imjasonh imjasonh mentioned this pull request Dec 26, 2023
Merged
@balazs92117 balazs92117 mentioned this pull request Jan 8, 2024
Closed
@joancafom joancafom mentioned this pull request Jan 10, 2024
Merged
3 tasks
@tcnghia tcnghia mentioned this pull request Feb 22, 2024
Merged
@dVerhees dVerhees mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 left review comments

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@strongjz strongjz

@tao12345666333 tao12345666333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rikatz @k8s-ci-robot @tao12345666333 @strongjz