Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance testing in PRs #8033

Closed
rikatz opened this issue Dec 12, 2021 · 10 comments
Closed

Performance testing in PRs #8033

rikatz opened this issue Dec 12, 2021 · 10 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rikatz
Copy link
Contributor

rikatz commented Dec 12, 2021

We need a conformance test that can provide us information like “amount of requests, time taken, errors” for our PRs so we can know how improved or degraded our performance was.

Imo there’s no need to know how to code here but mostly we need to establish:
set of important tests (like single http, long running http, tls, 100 simultaneous connections, etc)

  • We don’t need to run all the e2e and corner cases here, but we need to run tests for scenarios that impacts 95% of our use cases
  • Think in a way to test and export those metrics (like a gh action that runs, exports the metrics and post them somewhere we can consume later) we probably want to use prow for this
  • implement this test as “optional” (non blocking) but in a way we can have a performance history of ingress

Who’s up to doing that? Required knowledge/opportunity to learn:

  • learn how to test an http server
  • Learn how to export metrics (prom gateway? Json? Google docs? :P)
  • Optionally prow if we run this in test-infra

Suggested approach:

Using k6 + https://k6.io/blog/load-testing-using-github-actions/

/help
/triage accepted
/priority important-soon
/kind feature

@rikatz rikatz added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 12, 2021
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 12, 2021
@tao12345666333
Copy link
Member

It doesn't look complicated. However, we need consider the results reporting and persistence.

Maybe test-infra already has some feasible solutions.

@longwuyuan
Copy link
Contributor

I am interested but i commented in thread on slack that I have some idea about https://locust.io but no idea of k6.io or js (k6.io uses js)

@tao12345666333
Copy link
Member

I tried k6 and it didn't seem to be difficult. Need to design a suitable test plan.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2022
@rikatz
Copy link
Contributor Author

rikatz commented Mar 17, 2022

/remove-lifecycle stale
News on this folks?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2022
@rikatz
Copy link
Contributor Author

rikatz commented May 10, 2022

/lifecycle frozen
/assign @tao12345666333
/assign @longwuyuan

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label May 10, 2022
@longwuyuan
Copy link
Contributor

/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 12, 2022
@longwuyuan
Copy link
Contributor

k6 implemented by me and used by @strongjz already

@longwuyuan
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@longwuyuan: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants