Improve upstream-vhost annotation to affect gRPC upstreams

[apolovov]

There is nginx.ingress.kubernetes.io/upstream-vhost annotation. It works only if backend-protocol is HTTP or HTTPS. But if I use GRPC, this annotation does nothing.

The gRPC request also have vhost header (:authority) and I can set it with the snippet:

    nginx.ingress.kubernetes.io/backend-protocol: GRPC
    nginx.ingress.kubernetes.io/configuration-snippet: |
      grpc_set_header      Host        foo.bar.svc.cluster.local;

So why I can't do it with upstream-vhost annotation? It does almost the same thing (proxy_set_header instead of grpc_set_header in my example).

/kind feature

[k8s-ci-robot]

@apolovov: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

I think because http://nginx.org/en/docs/http/ngx_http_grpc_module.html#grpc_set_header is a different directive than proxy_set_header. Will check. @***@***.*** ***@***.***> would you you want to discuss this. /kind feature Thanks, ; Long

…

On Thu, 5 Aug, 2021, 6:26 AM Kubernetes Prow Robot, < ***@***.***> wrote: @apolovov <https://github.com/apolovov>: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance. The triage/accepted label can be added by org members by writing /triage accepted in a comment. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7436 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWULYF2FAOCD765P2O3T3HOS5ANCNFSM5BSLT3UQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[rikatz]

I would accept a PR for this without any problem :)

Here is what to change:
https://github.com/kubernetes/ingress-nginx/blob/main/rootfs/etc/nginx/template/nginx.tmpl#L1222-L1228

We have an if, verifying if the directive is {{ if not (eq $proxySetHeader "grpc_set_header") }}

I don't know the implication of removing this if, and why it happens BUT the file is there :)

[rikatz]

@kd7lxl wdyt about this?

[kd7lxl]

#3706 (comment) describes why the current behavior was chosen.

I'm not familiar with all the nuances of rfc7540, but I think the appropriate behavior for a reverse proxy with an upstream-vhost override would be to rewrite the :authority header for gRPC backends rather than the Host header.

[rikatz]

So the behavior is right?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.