Plugin access method don't work

[stamm]

If you use plugin, for example this one: https://github.com/kubernetes/ingress-nginx/blob/master/rootfs/etc/nginx/lua/plugins/hello_world/main.lua

Method access would not be called.

This bug introduced in #4007

[ElvinEfendi]

@stamm you can find in the description of that PR why I had to do it. I still haven't figured out a good way of supporting access phase. I'll probably just go ahead and remove access phase from that example and document that access phase is not available for plugins.

Even though certain access related things are better fit for access phase conceptually, technically speaking you can just run them in rewrite phase.

Let me know if you have a better idea for supporting access phase for plugins.

[stamm]

Maybe we can determinate on start if any plugins have access method, and in this case add plugins.run() to access_by_lua_block?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[ElvinEfendi]

@stamm I don't have a strong reason to add complexity for supporting access phase. I need practical scenarios where running a plugin in access phase is necessary and can not be replaced by rewrite phase.

[stamm]

We change ingress and service name in plugin, if we have a special header or cookie.

I rename plugin's method from access method to rewrite.
For now, I just move this line up

ingress-nginx/rootfs/etc/nginx/template/nginx.tmpl

Line 984 in 75e8d37

plugins.run()

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.