Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successfully healthcheck only after generating the right template #122

Closed
gianrubio opened this issue Jan 10, 2017 · 4 comments
Closed

Successfully healthcheck only after generating the right template #122

gianrubio opened this issue Jan 10, 2017 · 4 comments

Comments

@gianrubio
Copy link
Contributor

1- Today I migrated the nginx controller to the latest version, using deployment strategy. During the deployment my ingress was down because the template was changed. After I adapt the template to the new version, the ingress was back.

The log was

[nginx-ingress-controller-54543-yvxty] W0110 10:14:03.384377       7 queue.go:87] requeuing kube-system/mypod, err template: nginx.tmpl:498:38: executing "nginx.tmpl" at <.PassthrougBackends>: can't evaluate field PassthrougBackends in type config.TemplateConfig
[nginx-ingress-controller-54543-yvxty] I0110 10:14:03.418421       7 leaderelection.go:247] lock is held by nginx-ingress-controller-54543-319ue and has not yet expired

For few seconds my applications was down. To avoid other users having the same issue, I propose to change the behaviour of healthcheck to only accept connections after generating the full template.

2- I'm not sure if when I was migrating the controller (with the right template) I got some nginx errors, probably because the nginx was generating the new template and using the default config, so my upstreams are empty. Can anyone confirm this issues?

@aledbf
Copy link
Member

aledbf commented Jan 10, 2017

@gianrubio please do not use the current master. If you want to test the controller please apply the PR #95

@gianrubio
Copy link
Contributor Author

@aledbf got it, could you confirm if this issues will be solved int this PR? Can I close this issue?

@aledbf
Copy link
Member

aledbf commented Jan 10, 2017

@gianrubio yes, is fixed

@aledbf
Copy link
Member

aledbf commented Jan 10, 2017

@gianrubio I want to merge #95 after another review.

haoqing0110 pushed a commit to stolostron/management-ingress that referenced this issue Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants