Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create parameter for disabling aio_write #10368

Closed
fabiorauber opened this issue Sep 5, 2023 · 3 comments · Fixed by #10394
Closed

Create parameter for disabling aio_write #10368

fabiorauber opened this issue Sep 5, 2023 · 3 comments · Fixed by #10394
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabiorauber
Copy link

In certain situations (like when enabling cache on the Ingress Nginx instance) it would be beneficial to have an option to disable aio_write in the Nginx configuration. I've stumbled upon an issue with stalled cache files that do not get updated until you restart Nginx (https://trac.nginx.org/nginx/ticket/2162), and the recommended workaround was to disable aio_write.

Unfortunately, to achieve this right now, it is necessary to customize the Nginx configuration template. Being just a feature flag, it would be easier if the Nginx Ingress Controller had an option to disable it.

@fabiorauber fabiorauber added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 5, 2023
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Sep 5, 2023
@rikatz
Copy link
Contributor

rikatz commented Sep 10, 2023

/triage accepted
/good-first-issue
/help

Seems simple to implement, but I would like someone to pick it as I have some other stuff on my queue now :)

@fabiorauber if you want page me on Slack and I can give you some directions, if you want to implement it!

@k8s-ci-robot
Copy link
Contributor

@rikatz:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/triage accepted
/good-first-issue
/help

Seems simple to implement, but I would like someone to pick it as I have some other stuff on my queue now :)

@fabiorauber if you want page me on Slack and I can give you some directions, if you want to implement it!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 10, 2023
@z1cheng
Copy link
Member

z1cheng commented Sep 10, 2023

Very happy to implement this feature if nobody is working on it 😉

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants