-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3586 from Shopify/disable-catch-all
Add --disable-catch-all option to disable catch-all server
- Loading branch information
Showing
9 changed files
with
172 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| /* | ||
| Copyright 2018 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package settings | ||
|
|
||
| import ( | ||
| "strings" | ||
|
|
||
| . "github.com/onsi/ginkgo" | ||
| appsv1beta1 "k8s.io/api/apps/v1beta1" | ||
|
|
||
| "k8s.io/ingress-nginx/test/e2e/framework" | ||
| ) | ||
|
|
||
| var _ = framework.IngressNginxDescribe("Disabled catch-all", func() { | ||
| f := framework.NewDefaultFramework("disabled-catch-all") | ||
|
|
||
| BeforeEach(func() { | ||
| f.NewEchoDeploymentWithReplicas(1) | ||
|
|
||
| framework.UpdateDeployment(f.KubeClientSet, f.IngressController.Namespace, "nginx-ingress-controller", 1, | ||
| func(deployment *appsv1beta1.Deployment) error { | ||
| args := deployment.Spec.Template.Spec.Containers[0].Args | ||
| args = append(args, "--disable-catch-all=true") | ||
| deployment.Spec.Template.Spec.Containers[0].Args = args | ||
| _, err := f.KubeClientSet.AppsV1beta1().Deployments(f.IngressController.Namespace).Update(deployment) | ||
|
|
||
| return err | ||
| }) | ||
| }) | ||
|
|
||
| AfterEach(func() { | ||
| }) | ||
|
|
||
| It("should ignore catch all Ingress", func() { | ||
| host := "foo" | ||
|
|
||
| ing := framework.NewSingleCatchAllIngress("catch-all", f.IngressController.Namespace, "http-svc", 80, nil) | ||
| f.EnsureIngress(ing) | ||
|
|
||
| ing = framework.NewSingleIngress(host, "/", host, f.IngressController.Namespace, "http-svc", 80, nil) | ||
| f.EnsureIngress(ing) | ||
|
|
||
| f.WaitForNginxServer(host, func(cfg string) bool { | ||
| return strings.Contains(cfg, "server_name foo") | ||
| }) | ||
|
|
||
| f.WaitForNginxServer("_", func(cfg string) bool { | ||
| return strings.Contains(cfg, `set $ingress_name ""`) && | ||
| strings.Contains(cfg, `set $proxy_upstream_name "upstream-default-backend"`) | ||
| }) | ||
| }) | ||
|
|
||
| // FIXME: This test doesn't work because of a bug in Ingress update handle in store package. | ||
| // It("should delete Ingress updated to catch-all", func() { | ||
| // host := "foo" | ||
|
|
||
| // ing := framework.NewSingleIngress(host, "/", host, f.IngressController.Namespace, "http-svc", 80, nil) | ||
| // f.EnsureIngress(ing) | ||
|
|
||
| // f.WaitForNginxServer(host, | ||
| // func(server string) bool { | ||
| // return strings.Contains(server, "server_name foo") | ||
| // }) | ||
|
|
||
| // resp, _, errs := gorequest.New(). | ||
| // Get(f.IngressController.HTTPURL). | ||
| // Set("Host", host). | ||
| // End() | ||
| // Expect(errs).To(BeNil()) | ||
| // Expect(resp.StatusCode).Should(Equal(http.StatusOK)) | ||
|
|
||
| // err := framework.UpdateIngress(f.KubeClientSet, f.IngressController.Namespace, host, func(ingress *extensions.Ingress) error { | ||
| // ingress.Spec.Rules = nil | ||
| // ingress.Spec.Backend = &extensions.IngressBackend{ | ||
| // ServiceName: "http-svc", | ||
| // ServicePort: intstr.FromInt(80), | ||
| // } | ||
| // return nil | ||
| // }) | ||
| // Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| // f.WaitForNginxConfiguration(func(cfg string) bool { | ||
| // return !strings.Contains(cfg, "server_name foo") && | ||
| // !strings.Contains(cfg, `set $ingress_name "foo"`) && | ||
| // !strings.Contains(cfg, `set $service_name "http-svc"`) | ||
| // }) | ||
|
|
||
| // resp, _, errs = gorequest.New(). | ||
| // Get(f.IngressController.HTTPURL). | ||
| // Set("Host", host). | ||
| // End() | ||
| // Expect(errs).To(BeNil()) | ||
| // Expect(resp.StatusCode).Should(Equal(http.StatusNotFound)) | ||
| // }) | ||
| }) |