Skip to content

Commit

Permalink
Fix e2e make targets
Browse files Browse the repository at this point in the history
  • Loading branch information
aledbf committed Dec 15, 2016
1 parent ac6930b commit 1c7cef5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
9 changes: 7 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,15 @@ clean:
controllers:
make -C controllers/nginx build

.PHONY: controllers-images
controllers-images:
.PHONY: docker-build
docker-build:
make -C controllers/nginx container

.PHONY: docker-push
docker-push:
make -C controllers/nginx push


.PHONY: ginkgo
ginkgo:
go get github.com/onsi/ginkgo/ginkgo
4 changes: 2 additions & 2 deletions hack/e2e.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func validWorkingDirectory() error {
if err != nil {
return fmt.Errorf("failed to convert %s to an absolute path: %v", cwd, err)
}
if !strings.Contains(filepath.Base(acwd), "ingress-controller") {
if !strings.Contains(filepath.Base(acwd), "ingress") {
return fmt.Errorf("must run from git root directory: %v", acwd)
}
return nil
Expand Down Expand Up @@ -214,7 +214,7 @@ func run(deploy deployer) error {
func Build() error {
// The build-release script needs stdin to ask the user whether
// it's OK to download the docker image.
cmd := exec.Command("make", "backends", "backends-images", "backends-push")
cmd := exec.Command("make", "docker-build", "docker-push")
cmd.Stdin = os.Stdin
if err := finishRunning("build-release", cmd); err != nil {
return fmt.Errorf("error building: %v", err)
Expand Down

0 comments on commit 1c7cef5

Please sign in to comment.