Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate upgrade tests to use the upgrade framework #951

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Migrate upgrade tests to use the upgrade framework #951

merged 1 commit into from
Nov 21, 2019

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Nov 20, 2019

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 20, 2019
@skmatti skmatti force-pushed the upgrade-test-cleanup branch from 736f0a8 to c98c394 Compare November 20, 2019 00:37
@skmatti skmatti mentioned this pull request Nov 20, 2019
Merged
@MrHohn
Copy link
Member

MrHohn commented Nov 20, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2019
@rramkumar1
Copy link
Contributor

@skmatti Can you split up the migration of each test into a single commit each?

@skmatti skmatti force-pushed the upgrade-test-cleanup branch from c98c394 to 6304afd Compare November 20, 2019 05:31
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 20, 2019
@skmatti skmatti force-pushed the upgrade-test-cleanup branch from 6304afd to 1b8f43c Compare November 20, 2019 05:35
@skmatti skmatti mentioned this pull request Nov 20, 2019
Merged
@skmatti
Copy link
Contributor Author

skmatti commented Nov 20, 2019

@skmatti Can you split up the migration of each test into a single commit each?

Done

@skmatti skmatti force-pushed the upgrade-test-cleanup branch from 1b8f43c to 26ad076 Compare November 20, 2019 06:11
@rramkumar1
Copy link
Contributor

@skmatti Can you split up the migration of each test into a single commit each?

Done

Am I missing it? I would expect to see 3 commits.

@skmatti
Copy link
Contributor Author

skmatti commented Nov 20, 2019

@skmatti Can you split up the migration of each test into a single commit each?

Done

Am I missing it? I would expect to see 3 commits.

Raised as separate PRs: #952, #921

rramkumar1
rramkumar1 reviewed Nov 21, 2019
View reviewed changes
pkg/e2e/interfaces.go Outdated Show resolved Hide resolved
cmd/e2e-test/common/common.go Outdated
"k8s.io/ingress-gce/pkg/fuzz/features"
)

func WaitForStableIngress(expectUnreachable bool, ing *v1beta1.Ingress, s *e2e.Sandbox, t *testing.T) *v1beta1.Ingress {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is WaitForStableIngress used for non-upgrade tests? If so, I wouldn't call s.PutStatus() here since the whole status is only used for upgrade tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvmd I see that its only used for upgrade tests. Can we put this in a shared place other than cmd/? It's weird to have library code in cmd/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this function is not needed, dissolved it.

@skmatti skmatti force-pushed the upgrade-test-cleanup branch from 26ad076 to 6a80d74 Compare November 21, 2019 18:57
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2019
@skmatti skmatti force-pushed the upgrade-test-cleanup branch from 6a80d74 to 3ef83d5 Compare November 21, 2019 19:06
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2019
@skmatti skmatti force-pushed the upgrade-test-cleanup branch from 3ef83d5 to 3267d90 Compare November 21, 2019 19:35
@skmatti skmatti force-pushed the upgrade-test-cleanup branch from 3267d90 to 8a2b727 Compare November 21, 2019 19:52
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2019
rramkumar1
rramkumar1 reviewed Nov 21, 2019
View reviewed changes
Copy link
Contributor

@rramkumar1 rramkumar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rramkumar1, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit b0e6d31 into kubernetes:master Nov 21, 2019
@skmatti skmatti deleted the upgrade-test-cleanup branch November 22, 2019 00:10
@skmatti skmatti mentioned this pull request Nov 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 rramkumar1 left review comments

@thockin thockin Awaiting requested review from thockin

Assignees

@MrHohn MrHohn

@rramkumar1 rramkumar1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skmatti @k8s-ci-robot @MrHohn @rramkumar1