Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unreferenced constants #89

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Delete unreferenced constants #89

merged 1 commit into from
Dec 22, 2017

Conversation

bowei
Copy link
Member

@bowei bowei commented Dec 22, 2017

deleteType,invalidPort,nameLenLimit

@bowei
Delete unreferenced constants
2a1f990 
deleteType,invalidPort,nameLenLimit
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 22, 2017
@nicksardo
Copy link
Contributor

lgtm

@nicksardo nicksardo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2017
@nicksardo nicksardo merged commit 5b9aa6f into kubernetes:master Dec 22, 2017
@bowei bowei deleted the delete-constants branch December 23, 2017 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nicksardo nicksardo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bowei @nicksardo @k8s-ci-robot