Add e2e make rule #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
Can you squash the commits? |
rramkumar1
force-pushed
the
add-e2e-make-rule
branch
from
37538c3 to
bba0aae
Compare
bowei
reviewed
Dec 22, 2017
Makefile
Outdated
| @@ -42,3 +42,9 @@ VERBOSE ?= 0 | |||
|
|
|||
| # Include standard build rules. | |||
| include build/rules.mk | |||
|
|
|||
| # Additional rule to build an image of glbc for e2e testing. | |||
| e2e: | |||
Add e2e target Add e2e target Add push for e2e target Addressed comments
rramkumar1
force-pushed
the
add-e2e-make-rule
branch
from
bba0aae to
eccfc53
Compare
MrHohn
reviewed
Dec 27, 2017
| @@ -42,3 +42,7 @@ VERBOSE ?= 0 | |||
|
|
|||
| # Include standard build rules. | |||
| include build/rules.mk | |||
|
|
|||
| # Additional rule to build an image of glbc for e2e testing. | |||
| push-e2e: | |||
There was a problem hiding this comment.
Probably put this into build/rules.mk?
There was a problem hiding this comment.
In rules.mk it says "These build rules should not need to be modified." I was under the impression that this meant new rules should not be added but I could be wrong.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new rule to the Makefile which pushes an image of glbc for e2e testing. This target basically does the same thing as a regular build and push but we need it for two reasons: