dump events in sandbox #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
bowei
reviewed
Jul 23, 2019
pkg/e2e/framework.go
Outdated
| @@ -207,6 +207,10 @@ func (f *Framework) RunWithSandbox(name string, t *testing.T, testFunc func(*tes | |||
| } | |||
|
|
|||
| testFunc(t, sandbox) | |||
|
|
|||
| if t.Failed() { | |||
| sandbox.DumpSandboxInfo() | |||
There was a problem hiding this comment.
why not always dump cluster events?
pkg/e2e/sandbox.go
Outdated
|
|
||
| // DumpSandboxInfo dumps information about the sandbox into logs | ||
| func (s *Sandbox) DumpSandboxInfo() { | ||
| s.dumpSandboxEvents() |
There was a problem hiding this comment.
The indirection is in case in the future we need to dump more category of info. (e.g. GCE objects )
freehan
changed the title
|
Ready fo another round |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumps events at the end of each test. Make it easier to debug e2e failure.