Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite updates for integration #785

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Composite updates for integration #785

merged 1 commit into from
Jun 27, 2019

Conversation

spencerhance
Copy link
Contributor

@spencerhance spencerhance commented Jun 25, 2019 •
edited
Loading

  • Add SSLCertificate to composites
  • Add Delete() and List() to composites
  • Add hand generated functions

A follow up PR will be added to rename the files in pkg/composite to be more clear

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 25, 2019
@k8s-ci-robot k8s-ci-robot requested review from freehan and MrHohn June 25, 2019 19:41
@rramkumar1
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2019
@spencerhance spencerhance force-pushed the composite-updates branch 4 times, most recently from a7c882c to faa6e68 Compare June 25, 2019 22:15
rramkumar1
rramkumar1 reviewed Jun 25, 2019
View reviewed changes
pkg/composite/util.go Outdated Show resolved Hide resolved
pkg/composite/util.go Outdated Show resolved Hide resolved
rramkumar1
rramkumar1 reviewed Jun 26, 2019
View reviewed changes
Copy link
Contributor

@rramkumar1 rramkumar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me

pkg/composite/manual.go Outdated Show resolved Hide resolved
pkg/composite/utils_test.go Outdated Show resolved Hide resolved
pkg/composite/utils_test.go Outdated Show resolved Hide resolved
pkg/composite/utils_test.go Outdated Show resolved Hide resolved
pkg/composite/utils_test.go Outdated Show resolved Hide resolved
pkg/composite/utils_test.go Outdated Show resolved Hide resolved
pkg/composite/utils_test.go Show resolved Hide resolved
@rramkumar1
Copy link
Contributor

/assign @bowei

for final approval

@bowei
Copy link
Member

bowei commented Jun 27, 2019

Let's make the parameter order to be the same in all functions:

cloud, key, version, [additional args]

@spencerhance
Copy link
Contributor Author

@bowei I updated the parameters and also re-formatted the template

@bowei
Copy link
Member

bowei commented Jun 27, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit f15a1f4 into kubernetes:master Jun 27, 2019
@spencerhance spencerhance deleted the composite-updates branch September 27, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 rramkumar1 left review comments

@freehan freehan Awaiting requested review from freehan

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spencerhance @k8s-ci-robot @rramkumar1 @bowei