Replace snapshotter in pkg/backends with a GCE cloud lister implementation that is solely used for garbage collection #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
…ation that is solely used for garbage collection
rramkumar1
force-pushed
the
remove-uses-of-snapshotter
branch
from
1ce2944 to
315742e
Compare
rramkumar1
changed the title
|
/assign @bowei |
agau4779
reviewed
Oct 23, 2018
| keyFunc := func(i interface{}) (string, error) { | ||
| bs := i.(*compute.BackendService) | ||
| if !namer.NameBelongsToCluster(bs.Name) { | ||
| return "", fmt.Errorf("unrecognized name %v", bs.Name) | ||
| } | ||
| return bs.Name, nil | ||
| } | ||
| backendPool.snapshotter = storage.NewCloudListingPool("backends", keyFunc, backendPool, 30*time.Second) | ||
| backendPool.gceLister = cloudlist.NewGCELister("backends", keyFunc, backendPool) |
There was a problem hiding this comment.
Do we need to share the backends lister with anything outside pkg/backends?
|
/assign @freehan |
|
Closing in favor of #590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pkg/backends uses a snapshotter which is used to keep some state on what backends that the controller managed. This snapshotter lists from the cloud periodically but this is unnecessary. We only need to list from the cloud when we are performing garbage collection.
This PR adds a new package called cloudlist which contains an implementation for a simple cloud lister that is decoupled from the existing snapshotter. The existing snapshotter implementation in pkg/backends is then replaced with the new cloud listing implementation.
The goal is to use the new cloud lister in pkg/loadbalancers and pkg/instances as well. Once this is done, the snapshotter code in pkg/pools can be completely removed.