Use HTTPS readiness probe for HTTP2 services because the Kubernetes A… #488
Conversation
…PI does not make a distinction between HTTPS and HTTP2 for probes.
k8s-ci-robot
added
needs-ok-to-test
k8s-ci-robot
added
the
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/cc @agau4779 |
|
@rramkumar1: GitHub didn't allow me to request PR reviews from the following users: agau4779. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hello - just checking in. Is there anything blocking this PR? It's a simple bug with a simple fix, so would be good to address sooner than later I think. @agau4779 @rramkumar1 |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anuraaga, bowei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…PI does not make a distinction between HTTPS and HTTP2 for probes.
Fixes #487