Make sure we get a BackendService after updating it to populate object fingerprint [WIP] #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Will think about this some more, and try to rearrange logic to avoid this issue in the first place. |
rramkumar1
changed the title
|
We can do this for now. It's easy. |
k8s-ci-robot
added
the
lgtm
bowei
reviewed
Jun 19, 2018
| @@ -311,6 +311,12 @@ func (b *Backends) ensureBackendService(sp utils.ServicePort, igLinks []string) | |||
| if err = composite.UpdateBackendService(be, b.cloud); err != nil { | |||
| return err | |||
| } | |||
| // Get the BackendService after an update so that the Fingerprint | |||
There was a problem hiding this comment.
does the update call itself return the new backendservice fingerprint? (may not need to call get against explicitly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that we had an update call without a corresponding get to update the fingerprint.
/assign @nicksardo
This change is