Simple web server for testing ingress-gce features #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bowei
reviewed
Jun 6, 2018
cmd/echo/app/handlers.go
Outdated
| w.Write([]byte(html.EscapeString(v))) | ||
| } | ||
|
|
||
| w.Write([]byte(fmt.Sprintf("remote-address: %v\n", r.RemoteAddr))) |
There was a problem hiding this comment.
Can we put this in a JSON and make it easier to parse?
There was a problem hiding this comment.
Problem is that there's only value in JSON if the entire body is JSON. The httputil dumper only returns a []byte, so we have no easy way of incorporating that into a JSON struct without killing the readability.
GET / HTTP/1.1
Host: localhost:8080
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9
Cache-Control: max-age=0
Connection: keep-alive
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36
{
"env": {
"Node": "",
"Pod": "",
"Namespace": ""
},
"remoteAddr": "[::1]:46372",
"tls": false,
"dump": "GET / HTTP/1.1\r\nHost: localhost:8080\r\nAccept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8\r\nAccept-Encoding: gzip, deflate, br\r\nAccept-Language: en-US,en;q=0.9\r\nCache-Control: max-age=0\r\nConnection: keep-alive\r\nUpgrade-Insecure-Requests: 1\r\nUser-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36\r\n\r\n"
}
There was a problem hiding this comment.
Will stop using httputil dump and hand-roll it:
{
"method": "GET",
"uri": "/",
"httpVersion": "1.1",
"k8sEnv": {
"Node": "",
"Pod": "",
"Namespace": ""
},
"remoteAddr": "[::1]:53408",
"tls": false,
"header": {
"Accept": [
"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8"
],
"Accept-Encoding": [
"gzip, deflate, br"
],
"Accept-Language": [
"en-US,en;q=0.9"
],
"Cache-Control": [
"max-age=0"
],
"Connection": [
"keep-alive"
],
"Upgrade-Insecure-Requests": [
"1"
],
"User-Agent": [
"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36"
]
}
}
cmd/echo/app/tls.go
Outdated
| "github.com/golang/glog" | ||
| ) | ||
|
|
||
| func createCert() (string, string) { |
|
/lgtm after you fix comments |
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.