Fix bug with ensuring BackendService settings + health checks #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the logical OR flow in ensureBackendService to ensure that no short-circuiting occurs. Because of this short circuit, when a BackendService was being ensured only the protocol would be ensured, not the health check or description. However, on subsequent syncs, health check and description would eventually get ensured. Regardless, it makes the code clearer to fix this.
Finally, this PR also ensures that we only get a legacy health check if the BackendService is pointing to one. Previously, we would always get it. This addresses nicksardo@'s comment in #269
/assign @nicksardo
This change is