Refactor gceurlmap to a struct representation #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
force-pushed
the
gceurlmap-refactor
branch
from
2ca3194 to
dd5bec2
Compare
k8s-ci-robot
added
size/L
rramkumar1
force-pushed
the
gceurlmap-refactor
branch
from
dd5bec2 to
7963173
Compare
|
The tests in controller_test.go need a really big refactor so I am commenting out the portions which cause the unit tests to fail for now. I would like to really dig into fixing how those tests are written in a separate PR. |
rramkumar1
force-pushed
the
gceurlmap-refactor
branch
from
7963173 to
fcb69c1
Compare
|
Decided to modify tests and fakes accordingly to make all tests work. Still want to dig deeper into controller_test.go later and fix it up. |
rramkumar1
force-pushed
the
gceurlmap-refactor
branch
from
fcb69c1 to
2fa7e1a
Compare
nicksardo
reviewed
May 9, 2018
| continue | ||
| } | ||
| pathToBackend := map[string]string{} | ||
| // Using a mapping of regex -> backend here ensures that we don't |
There was a problem hiding this comment.
Let's not use the word regex as this confuses users. Stick with path?
nicksardo
reviewed
May 9, 2018
pkg/utils/gceurlmap.go
Outdated
|
|
||
| // PathRule encapsulates the information for a single path -> backend mapping. | ||
| type PathRule struct { | ||
| // Path is a regex. |
rramkumar1
force-pushed
the
gceurlmap-refactor
branch
from
2fa7e1a to
0734d79
Compare
rramkumar1
force-pushed
the
gceurlmap-refactor
branch
from
0734d79 to
0e26a15
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix tests once approach looks good.
/assign @nicksardo