-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use field selector to get ASM configmap #2182
Conversation
Doing so avoids caching unneeded configmaps in memory. Signed-off-by: Eric Lin <[email protected]>
Welcome @linxiulei! |
Hi @linxiulei. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, linxiulei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Out of curiosity, did we see that there was a large configmap memory usage after changing to just the ASM namespace? |
No, not in practice. This PR is more of a cleanup than an optimization. |
Doing so avoids caching unneeded configmaps in memory.