Update logging in endpoint calculation. #2161
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @sawsa307. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
pkg/neg/syncers/utils.go
Outdated
| @@ -461,7 +461,7 @@ func toZoneNetworkEndpointMapDegradedMode(eds []negtypes.EndpointsData, zoneGett | |||
| // endpoint address should match to the IP of its pod | |||
| checkIPErr := podContainsEndpointAddress(networkEndpoint, pod) | |||
| if checkIPErr != nil { | |||
| klog.Errorf("Endpoint %q in Endpoints %s/%s has IP(s) not match to its pod %s: %v, skipping", endpointAddress.Addresses, ed.Meta.Namespace, ed.Meta.Name, pod.Name, checkIPErr) | |||
| klog.Errorf("Endpoint %q in Endpoints %s/%s has IP(s) not match to its pod %s: %v, skipping", networkEndpoint.IP, ed.Meta.Namespace, ed.Meta.Name, pod.Name, checkIPErr) | |||
There was a problem hiding this comment.
nit: Endpoint %q in Endpoints %s/%s has at least one IP that not match to its pod %s: %v, skipping
pkg/neg/syncers/utils.go
Outdated
| @@ -591,7 +591,7 @@ func podContainsEndpointAddress(networkEndpoint negtypes.NetworkEndpoint, pod *a | |||
| } | |||
| } | |||
| if matching != len(endpointIPs) { | |||
| return fmt.Errorf("%w: endpoint %v has IP(s) not match to its pod's IP(s)", negtypes.ErrEPIPNotFromPod, endpointIPs) | |||
| return fmt.Errorf("%w: endpoint has IP(s) %v not match to its pod's IP(s)", negtypes.ErrEPIPNotFromPod, endpointIPs) | |||
There was a problem hiding this comment.
reword: endpoint has at least one IP %v that does not match its pod's IP(s)
Update logging in endpoint calculation.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sawsa307, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Update logging in endpoint calculation.
The way to trigger this is by constructing a custom endpoint slice so that we contains two endpoints from EPS that share the same pod but contains different endpointIP. The reason we are seeing this is because for this endpoint, the IP we use for network endpoint(and used for this check) is different from the IP from the endpoint in EPS.
The first IP we have is the endpoint IP from EPS, and the later one is the one we used for network endpoint.