Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete syncers from metrics collector during GC #2094

Merged
merged 1 commit into from
May 3, 2023
Merged

Delete syncers from metrics collector during GC #2094

merged 1 commit into from
May 3, 2023

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented May 1, 2023

When a syncer is deleted, remove it from neg-metrics-collector to prevent stale entries.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2023
@sawsa307
Copy link
Contributor Author

sawsa307 commented May 1, 2023

cc @gauravkghildiyal

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sawsa307. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sawsa307
Copy link
Contributor Author

sawsa307 commented May 1, 2023

/assign @swetharepakula

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 1, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and code-elinka May 1, 2023 20:34
@sawsa307 sawsa307 changed the title Delete syncer from metrics collector during GC Delete syncers from metrics collector during GC May 1, 2023
gauravkghildiyal
gauravkghildiyal reviewed May 1, 2023
View reviewed changes
pkg/neg/metrics/neg_metrics_collector.go Outdated
@@ -32,6 +32,8 @@ type SyncerMetricsCollector interface {

SetSyncerEPMetrics(key negtypes.NegSyncerKey, epState *negtypes.SyncerEPStat)
SetLabelPropagationStats(key negtypes.NegSyncerKey, labelstatLabelPropagationStats LabelPropagationStats)
// DeleteSyncer deletes the syncer from the maps
DeleteSyncer(key negtypes.NegSyncerKey)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed in the interface. Can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks!

@sawsa307 sawsa307 force-pushed the delete-syncer-from-metrics-collector branch 2 times, most recently from 8bb7cfa to 27fcdf6 Compare May 1, 2023 21:04
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 1, 2023
@sawsa307 sawsa307 force-pushed the delete-syncer-from-metrics-collector branch from 27fcdf6 to 865e9c2 Compare May 1, 2023 21:11
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2023
@sawsa307
Delete syncer from metrics collector during GC
b22558e 
When a syncer is deleted, remove it from neg-metrics-collector to
prevent stale entries.
@sawsa307 sawsa307 force-pushed the delete-syncer-from-metrics-collector branch from 865e9c2 to b22558e Compare May 1, 2023 21:12
@swetharepakula
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2023
swetharepakula
swetharepakula reviewed May 2, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sawsa307, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@sawsa307
Copy link
Contributor Author

sawsa307 commented May 2, 2023

/retest

1 similar comment
@sawsa307
Copy link
Contributor Author

sawsa307 commented May 3, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8321bc1 into kubernetes:master May 3, 2023
@sawsa307 sawsa307 deleted the delete-syncer-from-metrics-collector branch September 2, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravkghildiyal gauravkghildiyal gauravkghildiyal left review comments

@swetharepakula swetharepakula swetharepakula left review comments

@aojea aojea Awaiting requested review from aojea

@code-elinka code-elinka Awaiting requested review from code-elinka

Assignees

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sawsa307 @k8s-ci-robot @swetharepakula @gauravkghildiyal