Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define endpoint state #1934

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Define endpoint state #1934

merged 2 commits into from
Feb 23, 2023

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented Feb 3, 2023

Define SyncerEPStat to store the count of endpoint and endpoint slices in different states. Define the states for endpoint and endpoint slices.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and freehan February 3, 2023 19:50
@k8s-ci-robot
Copy link
Contributor

Hi @sawsa307. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2023
@sawsa307
Copy link
Contributor Author

sawsa307 commented Feb 3, 2023

/assign @swetharepakula

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2023
@sawsa307 sawsa307 force-pushed the define-endpoint-state branch from 91ccf6e to 467ff51 Compare February 5, 2023 02:12
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2023
@bowei
Copy link
Member

bowei commented Feb 9, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2023
@sawsa307 sawsa307 force-pushed the define-endpoint-state branch from 467ff51 to b71fa43 Compare February 13, 2023 21:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 13, 2023
swetharepakula
swetharepakula reviewed Feb 13, 2023
View reviewed changes
pkg/neg/metrics/neg_metrics_collector.go Outdated Show resolved Hide resolved
pkg/neg/types/endpoint_stat.go Outdated
Comment on lines 40 to 48

func StateForEP() []State {
return []State{EPMissingNodeName, EPMissingPod, EPMissingZone, EPMissingField, EPDuplicate, EPTotal}
}

func StateForEPS() []State {
return []State{EPSWithMissingNodeName, EPSWithMissingPod, EPSWithMissingZone, EPSWithMissingField, EPSWithDuplicate, EPSTotal}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these functions used for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are used to make sure we go over each state when we export. I'll remove them for now and address this in the metrics PR. Thanks!

pkg/neg/types/endpoint_stat.go Outdated

type State string

func (s State) String() string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Thanks!

@sawsa307 sawsa307 force-pushed the define-endpoint-state branch 2 times, most recently from 4d9333b to e66e59f Compare February 16, 2023 02:24
@sawsa307 sawsa307 force-pushed the define-endpoint-state branch from e66e59f to 6179493 Compare February 16, 2023 21:05
swetharepakula
swetharepakula reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2023
@sawsa307 sawsa307 force-pushed the define-endpoint-state branch from 6179493 to 07f8b13 Compare February 17, 2023 01:49
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2023
@sawsa307 sawsa307 force-pushed the define-endpoint-state branch from 07f8b13 to 595009f Compare February 17, 2023 01:53
@sawsa307 sawsa307 force-pushed the define-endpoint-state branch 2 times, most recently from 2b835a7 to 009ccc7 Compare February 22, 2023 23:42
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2023
@sawsa307
define states for endpoints
bae296d
@sawsa307
Collect state counts for endpoint and endpoint slices
01f8e60 
Define SyncerEPStat to store the count of endpoint and endpoint slices
in different states. Define the states for endpoint and endpoint slices.
Collect state counts in neg metrics collector.
@sawsa307 sawsa307 force-pushed the define-endpoint-state branch from 009ccc7 to 01f8e60 Compare February 23, 2023 01:01
@swetharepakula
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sawsa307, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b2acb95 into kubernetes:master Feb 23, 2023
@sawsa307 sawsa307 deleted the define-endpoint-state branch September 2, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swetharepakula swetharepakula swetharepakula left review comments

@aojea aojea Awaiting requested review from aojea

@freehan freehan Awaiting requested review from freehan

Assignees

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sawsa307 @k8s-ci-robot @bowei @swetharepakula