Add option to enable proxy protocol RE:#699

[dcherniv]

Please refer to #699
This is desperately needed for feature parity with AWS.

[nesl247]

Any update?

[CapoD]

Currently, we are using GKE + Istio (automatically installed) and our applications need to know the source IP of a request.
Since Istio ingress-gateway service is configuring a TCP Load Balancer, we would need to enable the Proxy Protocol on the GCP LB. Unfortunately, this can only be done on creation.
So we would ask you to provide a service annotation that would allow us to set the Proxy Protocol (Version).
In AWS this can be done

[rramkumar1]

@bowei Is this something that can be addressed by the Gateway API?

/assign @bowei

[bowei]

It seems to make more sense as a value for app-protocol, may want to xref on k/k

[unixfox]

I'm also interested into this new annotation. I would like to deploy NGINX behind a TCP LB and I need to preserve the original IP address of the clients.

[gustavovalverde]

For people trying to preserve the client's Source IP using Nginx, there's no need to use Proxy Protocol, installing with this configuration will do it (use an updated Nginx):

  config:
    enable-real-ip: "true"
    use-forwarded-headers: "true"
    proxy-real-ip-cidr: "130.211.0.0/22,35.191.0.0/[L7-LB_EXTERNAL_IP]/32"

cc: @unixfox

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nesl247]

/reopen

[k8s-ci-robot]

@nesl247: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.