-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export utils for import tracking and refs #247
Export utils for import tracking and refs #247
Conversation
/cc @apelisse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a test being updated, shouldn't we have a test if this becomes a public method?
added local package test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, apelisse, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Avoids duplication of default tag parsing to be used in OpenAPI-gen
defaulter-gen
to parse symbols for use with OpenAPI.Also includes some cleanup around the ImportTracker since OpenAPI-gen also needs to use
AddSymbol
:NewImportTrackerForPackage
so that local package can be provided toDefaultImportTracker
AddSymbol
onImportTracker
to be used by OpenAPI-gen and defaulter-gensymbolTracker
interface since it is no longer necessaryrequired by kubernetes/kube-openapi#419