are --input-dirs directories or packages

[MHBauer]

Using lister-gen from https://github.com/kubernetes/kubernetes/tree/master/cmd/libs/go2idl/lister-gen

--input-dirs only accepts packages and not directories. Is lister-gen using the input-dirs argument incorrectly, or is the argument supposed to represent directories and not packages?

[thockin]

I think it is not well defined, but the ones I look at all use pkg names

…

On Mon, Feb 6, 2017 at 3:36 PM, Morgan Bauer ***@***.***> wrote: Using lister-gen from https://github.com/kubernetes/ kubernetes/tree/master/cmd/libs/go2idl/lister-gen --input-dirs only accepts packages and not directories. Is lister-gen using the input-dirs argument incorrectly, or is the argument supposed to represent directories and not packages? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#39>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVPKuTh02ZX2CaqDXjlb4J3x9guKAks5rZ65lgaJpZM4L43Ee> .

[MHBauer]

I have the same experience, which is what prompted the question. Can we consider changing that flag then? Or deprecating + hiding it and adding a new flag with the old flag as an alias? I wouldn't want to break everyone.

[thockin]

yeah, deprecating and hiding is a must. I'd be fine to change it to --input-pkgs or perhaps even just assume that non-flag args == input dirs. instead of `cmd --input-pkgs=foo,bar,bat` do `cmd foo bar bat`. Slightly larger change, but I think better. @lavalamp might know a reason not to do this...

…

On Mon, Feb 6, 2017 at 4:55 PM, Morgan Bauer ***@***.***> wrote: I have the same experience, which is what prompted the question. Can we consider changing that flag then? Or deprecating + hiding it and adding a new flag with the old flag as an alias? I wouldn't want to break everyone. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVJ8IFYRdLS9RtZbN2i1tUiL366gBks5rZ8DrgaJpZM4L43Ee> .

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[thockin]

/lifecycle frozen

[nikhita]

/remove-lifecycle stale

[thockin]

Will be fixed in v2 (#259)