KEP 1645: slightly relax the managed by requirements on EndpointSlices #4930
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MrFreezeex The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
kind/kep
k8s-ci-robot
added
the
size/XS
MrFreezeex
force-pushed
the
kep1645-relax-epslice-managed
branch
2 times, most recently
from
d737f35 to
81085a4
Compare
MrFreezeex
changed the title
MrFreezeex
force-pushed
the
kep1645-relax-epslice-managed
branch
from
81085a4 to
3babc13
Compare
tpantelis
reviewed
Oct 24, 2024
keps/sig-multicluster/1645-multi-cluster-services-api/README.md
Outdated
Show resolved
Hide resolved
MrFreezeex
force-pushed
the
kep1645-relax-epslice-managed
branch
from
3babc13 to
f21b174
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
skitt
reviewed
Oct 25, 2024
keps/sig-multicluster/1645-multi-cluster-services-api/README.md
Outdated
Show resolved
Hide resolved
Relax a bit the sentence about EndpointSlice marked as not managed by the endpointslice controller as some EndpointSlice might be actually managed by the endpointslice controller directly. For instance Cilium implementation currently uses the default endpointslice controller to manage the EndpointSlice from the local cluster. The sentence below still implies that imported EndpointSlice must be managed by a MCS-API controller which means that this mixed scenario can be conformant while still keeping a strong guideline for EndpointSlice managed by a MCS-API controller. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
MrFreezeex
force-pushed
the
kep1645-relax-epslice-managed
branch
from
f21b174 to
f341e9d
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm @JeremyOT WDYT? |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
This feels like a reasonable implementation and the clarification is still aligned with the original intent. /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance Cilium implementation currently uses the default endpointslice controller to manage the EndpointSlice from the local cluster.
The sentence below still implies that imported EndpointSlice must be managed by a MCS-API controller which means that this mixed scenario can be conformant while still keeping a strong guideline for EndpointSlice managed by a MCS-API controller.