Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in cgroup v2, memory.max_usage_in_bytes can be replaced by memory.peak #4782

Merged
merged 2 commits into from
Sep 20, 2024
Merged

in cgroup v2, memory.max_usage_in_bytes can be replaced by memory.peak #4782

merged 2 commits into from
Sep 20, 2024

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Aug 8, 2024 •
edited
Loading

xref #2371

torvalds/linux@8e20d4b

  • This feature was added to kernel in 5.19.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Aug 8, 2024

/cc @haircommander @bobbypage

@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Aug 9, 2024

/assign @dchen1107 @mrunalp @derekwaynecarr

SergeyKanzhelev
SergeyKanzhelev reviewed Aug 10, 2024
View reviewed changes
keps/sig-node/2371-cri-pod-container-stats/README.md Outdated
@@ -135,7 +135,7 @@ Below is a table describing which stats come from what source now, as well a pro
| |N/A |container_memory_failcnt |N/A |cAdvisor |CRI or N/A | memory.failcnt N/A
| |N/A |container_memory_failures_total |N/A |cAdvisor |CRI or N/A | (memory.stat) pg_fault && pg_maj_fault |
| |N/A |container_memory_mapped_file |N/A |cAdvisor |CRI or N/A | (memory.stat) mapped_file | (memory.stat) file_mapped
| |N/A |container_memory_max_usage_bytes |N/A |cAdvisor |CRI or N/A | memory.max_usage_in_bytes | memory.max
| |N/A |container_memory_max_usage_bytes |N/A |cAdvisor |CRI or N/A | memory.max_usage_in_bytes | memory.peak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be conditioned depending on a kernel version than?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v5.19 : torvalds/linux@8e20d4b

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No kernel version are mentioned in the KEP, so I added the link and kernel version in commit message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My ask is to mention the minimum kernel version in this KEP readme.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2024
SergeyKanzhelev
SergeyKanzhelev approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Aug 13, 2024

/assign @mrunalp @dchen1107

@mrunalp
Copy link
Contributor

mrunalp commented Sep 19, 2024

@giuseppe @kolyshkin ptal

giuseppe
giuseppe approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mrunalp
mrunalp approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mrunalp, pacoxu, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2395264 into master Sep 20, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@giuseppe giuseppe giuseppe approved these changes

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@bobbypage bobbypage Awaiting requested review from bobbypage

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@haircommander haircommander

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
8 participants
@pacoxu @haircommander @mrunalp @k8s-ci-robot @giuseppe @SergeyKanzhelev @derekwaynecarr @dchen1107