KEP 1645: update conditions in ServiceExport after KEP-1623 #4672

MrFreezeex · 2024-05-30T20:40:31Z

One-line PR description:
Update conditions after KEP-1623 on KEP-1645 which match the actual CRDs here: https://github.com/kubernetes-sigs/mcs-api/blob/master/pkg/apis/v1alpha1/serviceexport.go#L47.

Issue link: Multi-Cluster Services API #1645

Other comments: Also swap the "2/5 cluster disagree" in the conflict message example so that it's clear that the disagree sentence is for the service that we export and not from the oldest Service that we conflict with.

k8s-triage-robot · 2024-09-06T00:04:32Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lauralorenz · 2024-09-06T19:27:42Z

/remove-lifecycle stale

k8s-ci-robot · 2024-09-17T19:06:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrFreezeex
Once this PR has been reviewed and has the lgtm label, please ask for approval from jeremyot. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

keps/sig-multicluster/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

MrFreezeex · 2024-09-17T19:11:04Z

Following today's sig-multicluster meeting I am proposing to add a new condition to reflect if the local service export is directly involved with the conflict. I am not that familiar with Kubernetes conditions so it may be more suitable to encode that info in the reason of the existing "Conflict" condition for instance. Feel free to comment if you have opinion about how this extra info should be exposed!

keps/sig-multicluster/1645-multi-cluster-services-api/README.md

tpantelis · 2024-09-17T20:51:53Z

keps/sig-multicluster/1645-multi-cluster-services-api/README.md

  - type: Conflict
    status: "True"
    lastTransitionTime: "2020-03-30T01:33:55Z"
-    message: "Conflicting type. Using \"ClusterSetIP\" from oldest service export in \"cluster-1\". 2/5 clusters disagree."
+    reason: "Conflict"
+    message: "Conflicting type. 2/5 clusters disagree. Using \"ClusterSetIP\" from oldest service export in \"cluster-1\"."


I think the reason should be "ConflictingType".

Yes indeed, although maybe we could extend the reason to do what I wanted to do for LocalConflict instead of encoding the type as well (like having LocalConflict/ExternalConflict as a reason) WDYT?

So with some inspiration from your message on slack if we encode having a local conflict in the same condition it would be probably one of these:

- type: Conflict status: "True" lastTransitionTime: "2020-03-30T01:33:55Z" reason: "LocalConflict" message: "The local service type conflicts with other constituent clusters. 2/5 clusters disagree. Using \"ClusterSetIP\" from oldest service export in \"cluster-1\"."

- type: Conflict status: "True" lastTransitionTime: "2020-03-30T01:33:55Z" reason: "ConflictingType" message: "The local service type conflicts with other constituent clusters. 2/5 clusters disagree. Using \"ClusterSetIP\" from oldest service export in \"cluster-1\"."

So if going that route we would have to decide if we want to encode local/external conflict or the "type" of conflict within the reason.

Those are still a suggested options to implementers and not the exact message that they absolutely need to provide ofc.

tpantelis · 2024-09-17T20:55:15Z

keps/sig-multicluster/1645-multi-cluster-services-api/README.md

@@ -471,13 +455,22 @@ status:
  - type: Ready
    status: "True"
    lastTransitionTime: "2020-03-30T01:33:51Z"
-  - type: InvalidService
+    reason: "Ready"


nit but I don't think this should merely duplicate the type - if there's no other short reason that adds value then leave it blank.

I now remember why I did this, we actually cannot add a Condition with an empty reason

Do you mean the API service rejects it?

I am not sure who rejects it but I retested it and by removing one reason I got the following error:

time="2024-09-26T10:12:11.051078297Z" level=error msg="Reconciler error" ServiceImport="{rebel-base-mcsapi default}" controller=serviceimport controllerGroup=multicluster.x-k8s.io controllerKind=ServiceImport error="ServiceExport.multicluster.x-k8s.io \"rebel-base-mcsapi\" is invalid: status.conditions[0].reason: Invalid value: \"\": conditions[0].reason in body should be at least 1 chars long" name=rebel-base-mcsapi namespace=default reconcileID="\"9d39229b-9e9b-4c8d-81d8-5a6cfda7dd68\"" subsys=controller-runtime

K8s rejects it b/c Reason is required in metav1.Condition:

// This field may not be empty // +required // +kubebuilder:validation:Required // +kubebuilder:validation:MaxLength=1024 // +kubebuilder:validation:MinLength=1 // +kubebuilder:validation:Pattern=`^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$` Reason string `json:"reason" protobuf:"bytes,5,opt,name=reason"`

In the previous ServiceExportCondition it wasn't.

Also swap the "2/5 cluster disagree" in the conflict message so that it's clear that the disagree sentence is for the service we export and not from the oldest Service that we conflict with. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

Add extra information to indicate to the user via the new ServiceExportLocalConflict condition if the local service export is directly involved in the conflict. As ServiceExportConflict should be added on every ServiceExport involved whether or not the local service export is involved, users were not involved to grasp that information without manually checking the service exported on multiple clusters. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

k8s-triage-robot · 2024-12-30T16:47:59Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-01-29T17:21:50Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2025-02-28T18:03:32Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2025-02-28T18:03:37Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 30, 2024

k8s-ci-robot requested review from JeremyOT and palnabarun May 30, 2024 20:40

k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2024

MrFreezeex force-pushed the conditions-1645 branch from 773826d to ad87e76 Compare May 30, 2024 20:44

thockin assigned JeremyOT and lauralorenz Jun 7, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2024

tpantelis reviewed Sep 17, 2024

View reviewed changes

MrFreezeex force-pushed the conditions-1645 branch 2 times, most recently from b8eb3ea to 8f34a9e Compare September 18, 2024 09:14

MrFreezeex force-pushed the conditions-1645 branch from 8f34a9e to e4415cd Compare September 25, 2024 13:50

MrFreezeex added 2 commits October 1, 2024 18:43

MrFreezeex force-pushed the conditions-1645 branch from e4415cd to 66d3f05 Compare October 1, 2024 16:43

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 29, 2025

k8s-ci-robot closed this Feb 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KEP 1645: update conditions in ServiceExport after KEP-1623 #4672

KEP 1645: update conditions in ServiceExport after KEP-1623 #4672

MrFreezeex commented May 30, 2024 •

edited

Loading

k8s-triage-robot commented Sep 6, 2024

lauralorenz commented Sep 6, 2024

k8s-ci-robot commented Sep 17, 2024

MrFreezeex commented Sep 17, 2024 •

edited

Loading

tpantelis Sep 17, 2024

MrFreezeex Sep 18, 2024 •

edited

Loading

MrFreezeex Sep 19, 2024 •

edited

Loading

tpantelis Sep 17, 2024

MrFreezeex Sep 25, 2024

tpantelis Sep 25, 2024

MrFreezeex Sep 26, 2024

tpantelis Sep 26, 2024

k8s-triage-robot commented Dec 30, 2024

k8s-triage-robot commented Jan 29, 2025

k8s-triage-robot commented Feb 28, 2025

k8s-ci-robot commented Feb 28, 2025

KEP 1645: update conditions in ServiceExport after KEP-1623 #4672

KEP 1645: update conditions in ServiceExport after KEP-1623 #4672

Conversation

MrFreezeex commented May 30, 2024 • edited Loading

k8s-triage-robot commented Sep 6, 2024

lauralorenz commented Sep 6, 2024

k8s-ci-robot commented Sep 17, 2024

MrFreezeex commented Sep 17, 2024 • edited Loading

tpantelis Sep 17, 2024

Choose a reason for hiding this comment

MrFreezeex Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

MrFreezeex Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

tpantelis Sep 17, 2024

Choose a reason for hiding this comment

MrFreezeex Sep 25, 2024

Choose a reason for hiding this comment

tpantelis Sep 25, 2024

Choose a reason for hiding this comment

MrFreezeex Sep 26, 2024

Choose a reason for hiding this comment

tpantelis Sep 26, 2024

Choose a reason for hiding this comment

k8s-triage-robot commented Dec 30, 2024

k8s-triage-robot commented Jan 29, 2025

k8s-triage-robot commented Feb 28, 2025

k8s-ci-robot commented Feb 28, 2025

MrFreezeex commented May 30, 2024 •

edited

Loading

MrFreezeex commented Sep 17, 2024 •

edited

Loading

MrFreezeex Sep 18, 2024 •

edited

Loading

MrFreezeex Sep 19, 2024 •

edited

Loading