Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3857: Recursive Read-only (RRO) mounts: promote to Beta #4668

Merged
merged 1 commit into from
Jun 12, 2024
Merged

KEP-3857: Recursive Read-only (RRO) mounts: promote to Beta #4668

merged 1 commit into from
Jun 12, 2024

Conversation

AkihiroSuda
Copy link
Member

  • One-line PR description: KEP-3857: Recursive Read-only (RRO) mounts: promote to Beta

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 28, 2024
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2024
@AkihiroSuda AkihiroSuda mentioned this pull request May 28, 2024
Open
15 tasks
@AkihiroSuda AkihiroSuda force-pushed the rro branch 2 times, most recently from 244bc20 to 106b115 Compare May 28, 2024 15:41
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2024
@AkihiroSuda AkihiroSuda requested a review from haircommander June 4, 2024 01:04
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2024
@AkihiroSuda
Copy link
Member Author

@johnbelamaric Could you take a look?

soltysh
soltysh reviewed Jun 11, 2024
View reviewed changes
keps/sig-node/3857-rro-mounts/README.md Show resolved Hide resolved
keps/sig-node/3857-rro-mounts/README.md Outdated Show resolved Hide resolved
keps/sig-node/3857-rro-mounts/kep.yaml Outdated Show resolved Hide resolved
keps/sig-node/3857-rro-mounts/README.md Show resolved Hide resolved
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 11, 2024
Open
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2024
soltysh
soltysh reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade->downgrade section is required for beta promotion, it's acceptable the testing is performed manually and that section of the document highlights the steps.

keps/sig-node/3857-rro-mounts/README.md Outdated Show resolved Hide resolved
soltysh
soltysh approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
for PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, mrunalp, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@mrunalp
Copy link
Contributor

mrunalp commented Jun 12, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit e3906aa into kubernetes:master Jun 12, 2024
2 of 4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 12, 2024
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 13, 2024
Merged
@AkihiroSuda
Copy link
Member Author

Thanks for approval.

k/k PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mrunalp mrunalp mrunalp approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@mrunalp mrunalp

@dchen1107 dchen1107

@haircommander haircommander

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
7 participants
@AkihiroSuda @haircommander @k8s-ci-robot @mrunalp @soltysh @dchen1107 @johnbelamaric