Update random pod scaledown KEP for stable #4649

MinpengJin · 2024-05-22T11:16:08Z

linux-foundation-easycla · 2024-05-22T11:16:11Z

The committers listed above are authorized under a signed CLA.

✅ login: MinpengJin / name: Minpeng Jin (1c2d21c)

k8s-ci-robot · 2024-05-22T11:16:16Z

Welcome @MinpengJin!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-05-22T11:16:17Z

Hi @MinpengJin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xuzhenglun · 2024-05-27T11:24:35Z

/ok-to-test

MinpengJin · 2024-06-04T10:45:42Z

Could you please review this PR? @wojtek-t @alculquicondor

alculquicondor · 2024-06-04T15:26:53Z

/assign

alculquicondor · 2024-06-04T15:30:53Z

/assign @soltysh

keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/README.md

MinpengJin · 2024-06-09T04:44:08Z

I have already revised it; could please review it again? @alculquicondor

alculquicondor · 2024-06-10T13:29:43Z

/lgtm

MinpengJin · 2024-06-11T02:13:10Z

/assign @wojtek-t

wojtek-t · 2024-06-11T07:02:04Z

/approve PRR

/assign @soltysh - for SIG-level approval

k8s-ci-robot · 2024-06-11T07:02:07Z

@wojtek-t: GitHub didn't allow me to assign the following users: -, for, SIG-level, approval.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/approve PRR

/assign @soltysh - for SIG-level approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

soltysh

This document hasn't been touched in a while, so it's not up-to-date with the current template, available here: https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md

Mostly, it's missing a more detailed testing section (with units, integration and e2e explicitly listed out with coverage and links to testgrid).

But that's not a blocking thing to merge this KEP.

/lgtm
/approve
from sig-apps pov

/hold
for addressing the missing bits

soltysh · 2024-06-11T11:02:50Z

keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/README.md

@@ -208,7 +208,7 @@ Beta (v1.22):
 - Enable LogarithmicScaleDown feature gate by default
 - Enable `sorting_deletion_age_ratio` metric

-Stable (v1.23):
+Stable (v1.31):
 - Remove LogarithmicScaleDown feature gate


Nit, we're not removing the feature gate, yet. We're only locking it to true.

soltysh · 2024-06-11T11:06:29Z

keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/README.md

  Assumptions that the newest pod will be deleted first may break.

-* **Are there any tests for feature enablement/disablement?**
+###### Are there any tests for feature enablement/disablement?
  Tests for feature disablement shouldn't be necessary, as this is already an assumed 
  (but not documented) controller behavior.

 ### Rollout, Upgrade and Rollback Planning

 _This section must be completed when targeting beta graduation to a release._


You can drop this line entirely.

soltysh · 2024-06-11T11:07:04Z

keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/README.md


-* **Is the rollout accompanied by any deprecations and/or removals of features, APIs, 
-fields of API types, flags, etc.?**
+###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
  No

 ### Monitoring Requirements

 _This section must be completed when targeting beta graduation to a release._


Similarly - drop this line entirely.

soltysh · 2024-06-11T11:08:06Z

keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/README.md

-  Describe the metrics themselves and the reasons why they weren't added (e.g., cost,
-  implementation difficulties, etc.).
+###### Are there any missing metrics that would be useful to have to improve observability of this feature?
+  No, we didn't find any other gaps that could be covered by metrics.

 ### Dependencies

 _This section must be completed when targeting beta graduation to a release._


Again, drop this line, not needed.

soltysh · 2024-06-11T11:08:40Z

keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/README.md

@@ -329,28 +336,27 @@ _For beta, this section is required: reviewers must answer these questions._
 _For GA, this section is required: approvers should be able to confirm the
 previous answers based on experience in the field._


This line and the above up until title can be safely dropped.

soltysh · 2024-06-11T11:10:17Z

keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/README.md

@@ -359,14 +365,14 @@ details). For now, we leave it here.

 _This section must be completed when targeting beta graduation to a release._


Again - remove.

I have locked the feature gate to true, and removed the unnecessary content @soltysh

k8s-ci-robot · 2024-06-11T11:11:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MinpengJin, soltysh, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~keps/prod-readiness/OWNERS~~ [soltysh,wojtek-t]
~~keps/sig-apps/OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wojtek-t · 2024-06-12T05:40:29Z

/lgtm
/hold cancel

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 22, 2024

k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels May 22, 2024

k8s-ci-robot requested review from johnbelamaric and soltysh May 22, 2024 11:16

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 22, 2024

MinpengJin force-pushed the log-sacledown-featuregate-stable branch from a3075ba to 0ad54c7 Compare May 22, 2024 11:22

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 22, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2024

xuzhenglun mentioned this pull request May 27, 2024

Random Pod selection on ReplicaSet downscaling #2185

Closed

12 tasks

wojtek-t self-assigned this May 27, 2024

k8s-ci-robot assigned alculquicondor Jun 4, 2024

k8s-ci-robot assigned soltysh Jun 4, 2024

alculquicondor reviewed Jun 4, 2024

View reviewed changes

keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/README.md Show resolved Hide resolved

MinpengJin force-pushed the log-sacledown-featuregate-stable branch from 0ad54c7 to ec1b2ba Compare June 5, 2024 11:08

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2024

alculquicondor reviewed Jun 5, 2024

View reviewed changes

MinpengJin force-pushed the log-sacledown-featuregate-stable branch 2 times, most recently from 1587750 to 2dd4fbc Compare June 8, 2024 02:00

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2024

soltysh approved these changes Jun 11, 2024

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024

Update random pod scaledown KEP for stable

1c2d21c

MinpengJin force-pushed the log-sacledown-featuregate-stable branch from 2dd4fbc to 1c2d21c Compare June 12, 2024 02:54

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2024

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 12, 2024

k8s-ci-robot merged commit 1f17939 into kubernetes:master Jun 12, 2024
4 checks passed

k8s-ci-robot added this to the v1.31 milestone Jun 12, 2024

xuzhenglun mentioned this pull request Jun 16, 2024

Promote LogarithmicScaleDown to GA kubernetes/kubernetes#125459

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update random pod scaledown KEP for stable #4649

Update random pod scaledown KEP for stable #4649

MinpengJin commented May 22, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 22, 2024 •

edited

Loading

k8s-ci-robot commented May 22, 2024

k8s-ci-robot commented May 22, 2024

xuzhenglun commented May 27, 2024

MinpengJin commented Jun 4, 2024

alculquicondor commented Jun 4, 2024

alculquicondor commented Jun 4, 2024

MinpengJin commented Jun 9, 2024

alculquicondor commented Jun 10, 2024

MinpengJin commented Jun 11, 2024

wojtek-t commented Jun 11, 2024

k8s-ci-robot commented Jun 11, 2024

soltysh left a comment

soltysh Jun 11, 2024

soltysh Jun 11, 2024

soltysh Jun 11, 2024

soltysh Jun 11, 2024

soltysh Jun 11, 2024

soltysh Jun 11, 2024

MinpengJin Jun 12, 2024

k8s-ci-robot commented Jun 11, 2024

wojtek-t commented Jun 12, 2024

		@@ -329,28 +336,27 @@ _For beta, this section is required: reviewers must answer these questions._
		_For GA, this section is required: approvers should be able to confirm the
		previous answers based on experience in the field._

		@@ -359,14 +365,14 @@ details). For now, we leave it here.

		_This section must be completed when targeting beta graduation to a release._

Update random pod scaledown KEP for stable #4649

Update random pod scaledown KEP for stable #4649

Conversation

MinpengJin commented May 22, 2024 • edited Loading

linux-foundation-easycla bot commented May 22, 2024 • edited Loading

k8s-ci-robot commented May 22, 2024

k8s-ci-robot commented May 22, 2024

xuzhenglun commented May 27, 2024

MinpengJin commented Jun 4, 2024

alculquicondor commented Jun 4, 2024

alculquicondor commented Jun 4, 2024

MinpengJin commented Jun 9, 2024

alculquicondor commented Jun 10, 2024

MinpengJin commented Jun 11, 2024

wojtek-t commented Jun 11, 2024

k8s-ci-robot commented Jun 11, 2024

soltysh left a comment

Choose a reason for hiding this comment

soltysh Jun 11, 2024

Choose a reason for hiding this comment

soltysh Jun 11, 2024

Choose a reason for hiding this comment

soltysh Jun 11, 2024

Choose a reason for hiding this comment

soltysh Jun 11, 2024

Choose a reason for hiding this comment

soltysh Jun 11, 2024

Choose a reason for hiding this comment

soltysh Jun 11, 2024

Choose a reason for hiding this comment

MinpengJin Jun 12, 2024

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 11, 2024

wojtek-t commented Jun 12, 2024

MinpengJin commented May 22, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 22, 2024 •

edited

Loading