-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-3157: correct description of cachewatcher channel #4361
Conversation
Signed-off-by: likakuli <[email protected]>
Welcome @likakuli! |
Hi @likakuli. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Seems reasonable to test, since refs: incoming (cacher): https://github.com/kubernetes/kubernetes/blob/2b5c0c281d7d3b75ed7df683f09339147c4a17e9/staging/src/k8s.io/apiserver/pkg/storage/cacher/cacher.go#L252 will let api-machinery-reviewers take a look. /ok-to-test |
@p0lyn0mial could you please help to review this change, thx |
/lgtm thanks! |
/assign @deads2k for approval. |
matching code precisely isn't required, but since the update is here /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, likakuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
correct description about cacherWatcher channel.
incoming chan is a property of Cacher and input chan is a property of cacheWatcher