Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dynamic kubelet config completely #3605

Merged
merged 1 commit into from
Oct 10, 2022
Merged

remove dynamic kubelet config completely #3605

merged 1 commit into from
Oct 10, 2022

Conversation

SergeyKanzhelev
Copy link
Member

/sig node
KEP: #281
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2022
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Oct 10, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2022
@SergeyKanzhelev
Copy link
Member Author

Since the work was planned and ongoing and there were no feedback recieved that will change plans, I'd suggest to take this KEP in 1.26

PR: kubernetes/kubernetes#112643

@SergeyKanzhelev SergeyKanzhelev force-pushed the updateDynamicKubeletConfig branch from 7f0d715 to 07fb5eb Compare October 10, 2022 17:57
@SergeyKanzhelev SergeyKanzhelev force-pushed the updateDynamicKubeletConfig branch from 07fb5eb to fa4113d Compare October 10, 2022 17:59
@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9f090fe into kubernetes:master Oct 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 10, 2022
@SergeyKanzhelev SergeyKanzhelev deleted the updateDynamicKubeletConfig branch October 10, 2022 19:07
@rhockenbury rhockenbury mentioned this pull request Oct 29, 2022
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
3 participants
@SergeyKanzhelev @dchen1107 @k8s-ci-robot