Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change status to implementable for feature tags alignment #3602

Merged
merged 1 commit into from
Oct 7, 2022
Merged

change status to implementable for feature tags alignment #3602

merged 1 commit into from
Oct 7, 2022

Conversation

SergeyKanzhelev
Copy link
Member

/sig testing
/sig node

Fix up the status of a KEP: #3041

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 7, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2022
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Oct 7, 2022
Open
@SergeyKanzhelev SergeyKanzhelev marked this pull request as ready for review October 7, 2022 21:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2022
@SergeyKanzhelev
Copy link
Member Author

hm, I don't really want to trigger the prod readiness review for this KEP. Maybe this is not needed. Asked here if it is needed: #3041 (comment)

BenTheElder
BenTheElder reviewed Oct 7, 2022
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

but, pending PRR question: https://kubernetes.slack.com/archives/CPNHUMN74/p1665177817264029

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2022
@SergeyKanzhelev SergeyKanzhelev force-pushed the nodeFeaturesImplementeable branch from 2068301 to aff0e8c Compare October 7, 2022 21:55
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2022
@SergeyKanzhelev
Copy link
Member Author

Waiting on the result of a discussion in https://kubernetes.slack.com/archives/CPNHUMN74/p1665177817264029

@SergeyKanzhelev SergeyKanzhelev force-pushed the nodeFeaturesImplementeable branch 2 times, most recently from a1d9646 to 3c7491d Compare October 7, 2022 22:01
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, johnbelamaric, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2022
@SergeyKanzhelev SergeyKanzhelev force-pushed the nodeFeaturesImplementeable branch from 3c7491d to a4d8483 Compare October 7, 2022 23:23
BenTheElder
BenTheElder reviewed Oct 7, 2022
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2cd758c into kubernetes:master Oct 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 7, 2022
@SergeyKanzhelev SergeyKanzhelev deleted the nodeFeaturesImplementeable branch October 9, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@cjwagner cjwagner Awaiting requested review from cjwagner

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
4 participants
@SergeyKanzhelev @k8s-ci-robot @johnbelamaric @BenTheElder