-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1731 : Publishing Kubernetes packages on community infrastructure #3434
Conversation
/cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to address the complete story of how packages will move from build artifact to repository. I added a couple of comments below:
Hey @RobertKielty, any update on this KEP? :) |
Hi @saschagrunert , I've not been able to work on this as I've started a new job and have been busy with that. I'll might be able to take a look at this again in a few weeks but it might be better by to hand it over to someone else. |
f75dc16
to
ebce886
Compare
ebce886
to
c537e02
Compare
Added the changes required for review, thank y'all and PTAL again. |
PTAL again @kubernetes/release-managers @detiber @RobertKielty @leonardpahlke @ameukam For approval: PTAL @kubernetes/sig-release-leads I'd like to see that PR being merged or abandoned before KubeCon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more tiny nits.
6a2c3a2
to
813f6a5
Compare
/lgtm |
/lgtm |
/check-cla |
/lgtm thanks for driving this! |
/lgtm thanks |
- Defines the Release Manager and End User roles - Removes refs to anago - Adds or fixes refs for officially documented package mirror Gherkin reference kubepkg Co-authored-by: Sascha Grunert <[email protected]> Signed-off-by: Sascha Grunert <[email protected]>
813f6a5
to
f27545d
Compare
According to the above /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RobertKielty, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Other comments:
Adds or fixes refs for
This is an initial attempt to revive this KEP by bringing it into line with all of the tooling improvements that have been made by the SIG Release Team since this KEP was first written.
It will we will need careful review of experienced SIG Release Team members
Specifically, I would ask the following of reviewers: