Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-1731 : Publishing Kubernetes packages on community infrastructure #3434

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

RobertKielty
Copy link
Member

Other comments:

  • Defines the Release Manager and End User roles
  • Removes references to anago (name of a bash script formerly used in this space) anago functionality has been re-implemented as a go module and subsumed into the krel command.
  • Added proper noun capitalization for defined roles

Adds or fixes refs for

  • the "officially documented package mirror"
  • a Gherkin reference for the user stories
  • kubepkg

This is an initial attempt to revive this KEP by bringing it into line with all of the tooling improvements that have been made by the SIG Release Team since this KEP was first written.

It will we will need careful review of experienced SIG Release Team members

Specifically, I would ask the following of reviewers:

  1. Let's review and re-validate all Motivations for this work are they still correct and accurate?
  2. Let's review and ensure that the User Stories are correct based on current Release Manager processes
  3. Do the User Stories completely cover and describe all requirements?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2022
@k8s-ci-robot k8s-ci-robot requested a review from puerco July 15, 2022 14:34
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jul 15, 2022
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jul 15, 2022
@leonardpahlke
Copy link
Member

/cc

keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to address the complete story of how packages will move from build artifact to repository. I added a couple of comments below:

keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2022
@saschagrunert
Copy link
Member

saschagrunert commented Aug 24, 2022

Hey @RobertKielty, any update on this KEP? :)

@RobertKielty
Copy link
Member Author

Hi @saschagrunert , I've not been able to work on this as I've started a new job and have been busy with that.

I'll might be able to take a look at this again in a few weeks but it might be better by to hand it over to someone else.

@saschagrunert saschagrunert force-pushed the KEP-1731 branch 8 times, most recently from f75dc16 to ebce886 Compare October 11, 2022 09:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2022
@saschagrunert
Copy link
Member

Added the changes required for review, thank y'all and PTAL again.

@saschagrunert
Copy link
Member

PTAL again @kubernetes/release-managers @detiber @RobertKielty @leonardpahlke @ameukam

For approval: PTAL @kubernetes/sig-release-leads

I'd like to see that PR being merged or abandoned before KubeCon.

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more tiny nits.

keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
keps/sig-release/1731-publishing-packages/README.md Outdated Show resolved Hide resolved
@xmudrii
Copy link
Member

xmudrii commented Oct 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2022
@jeremyrickard
Copy link
Contributor

/lgtm

@saschagrunert
Copy link
Member

/check-cla

@dims
Copy link
Member

dims commented Oct 18, 2022

/lgtm

thanks for driving this!

@cpanato
Copy link
Member

cpanato commented Oct 18, 2022

/lgtm

thanks

 - Defines the Release Manager and End User roles
 - Removes refs to anago
 - Adds or fixes refs for
   officially documented package mirror
   Gherkin reference
   kubepkg

Co-authored-by: Sascha Grunert <[email protected]>
Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2022
@saschagrunert
Copy link
Member

saschagrunert commented Oct 19, 2022

According to the above lgtm's from other @kubernetes/sig-release-leads than myself:

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RobertKielty, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@xmudrii
Copy link
Member

xmudrii commented Oct 19, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 18803c1 into kubernetes:master Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 19, 2022
@saschagrunert saschagrunert deleted the KEP-1731 branch October 19, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.