-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1487: Add csi migration kep for AWS EBS #3108
Conversation
/lgtm |
/milestone v1.24 |
/lgtm |
/assign @ehashman |
@msau42 @ehashman @Jiawei0227 - I'm wondering if (given that I'm approving the PRR for the main CSI migration KEP now to GA and previously Beta), maybe it makes sense to reassign all of these sibling provider-related ones to me too? I'm happy to take them |
Thanks a lot! I will reassign them to you! |
/assign @wojtek-t |
Ah, I did a bunch of these last release... just looked through one or two but only saw this comment now. I think that's fine. I also ran through the questionnaire and it generally looked good to me for beta. I did have one concern: enhancements/keps/sig-storage/625-csi-migration/README.md Lines 409 to 410 in 6ec5481
"Read the logs" isn't really troubleshooting guidance. I'd expect this to indicate what people should specifically be looking for in the logs, and not just suggest that they should check them. :) |
That's a fair point. |
Sure, I created a PR: #3152. hopefully this provides some debugging process to trouble shoot any potential errors/issues. |
I will leave @wojtek-t as the approver and unassign these PRs. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jiawei0227 - One minor comment
/hold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jiawei0227, msau42, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@msau42 - should we cancel hold? |
Yeah sounds good to me. /hold cancel |
retroactive 👍 thx all. |
This PR adds csi migration kep for aws-ebs