Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-1487: Add csi migration kep for AWS EBS #3108

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

Jiawei0227
Copy link
Contributor

  • One-line PR description:
    This PR adds csi migration kep for aws-ebs
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 5, 2022
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jan 5, 2022
@Jiawei0227
Copy link
Contributor Author

/cc @msau42 @xing-yang @wongma7 @ehashman

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2022
@xing-yang
Copy link
Contributor

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 6, 2022
@msau42
Copy link
Member

msau42 commented Jan 8, 2022

/lgtm
/approve

@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 11, 2022
@msau42
Copy link
Member

msau42 commented Jan 14, 2022

/assign @ehashman

@wojtek-t
Copy link
Member

@msau42 @ehashman @Jiawei0227 - I'm wondering if (given that I'm approving the PRR for the main CSI migration KEP now to GA and previously Beta), maybe it makes sense to reassign all of these sibling provider-related ones to me too? I'm happy to take them

@Jiawei0227
Copy link
Contributor Author

@msau42 @ehashman @Jiawei0227 - I'm wondering if (given that I'm approving the PRR for the main CSI migration KEP now to GA and previously Beta), maybe it makes sense to reassign all of these sibling provider-related ones to me too? I'm happy to take them

Thanks a lot! I will reassign them to you!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2022
@Jiawei0227
Copy link
Contributor Author

/assign @wojtek-t

@ehashman
Copy link
Member

@msau42 @ehashman @Jiawei0227 - I'm wondering if (given that I'm approving the PRR for the main CSI migration KEP now to GA and previously Beta), maybe it makes sense to reassign all of these sibling provider-related ones to me too? I'm happy to take them

Ah, I did a bunch of these last release... just looked through one or two but only saw this comment now.

I think that's fine. I also ran through the questionnaire and it generally looked good to me for beta. I did have one concern:

* **What steps should be taken if SLOs are not being met to determine the problem?**
- Take the CSI driver log, kube-controller-manager log and kubelet log to analyze why the SLOs are not being met. What is the most error status and why is it error.

"Read the logs" isn't really troubleshooting guidance. I'd expect this to indicate what people should specifically be looking for in the logs, and not just suggest that they should check them. :)

@wojtek-t
Copy link
Member

"Read the logs" isn't really troubleshooting guidance. I'd expect this to indicate what people should specifically be looking for in the logs, and not just suggest that they should check them. :)

That's a fair point.
@Jiawei0227 - can you please extend that in the main CSI migration kep PRR?

@Jiawei0227
Copy link
Contributor Author

That's a fair point.
@Jiawei0227 - can you please extend that in the main CSI migration kep PRR?

Sure, I created a PR: #3152. hopefully this provides some debugging process to trouble shoot any potential errors/issues.

@ehashman
Copy link
Member

I will leave @wojtek-t as the approver and unassign these PRs. Thanks!

@ehashman ehashman removed their assignment Jan 18, 2022
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jiawei0227 - One minor comment

keps/prod-readiness/sig-storage/1487.yaml Outdated Show resolved Hide resolved
@msau42
Copy link
Member

msau42 commented Jan 21, 2022

/hold
@wongma7 to confirm if we want to target 1.24

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2022
@wojtek-t
Copy link
Member

/lgtm
/approve PRR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jiawei0227, msau42, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@wojtek-t
Copy link
Member

@msau42 - should we cancel hold?
If we decide not to proceed later in the cycle, we can always do that. If this will miss the deadline, we won't be able to recover from it.

@msau42
Copy link
Member

msau42 commented Jan 26, 2022

Yeah sounds good to me.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit a09ea5b into kubernetes:master Jan 26, 2022
@wongma7
Copy link
Contributor

wongma7 commented Jan 26, 2022

retroactive 👍

thx all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants