-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod Resource API: Explicitly clarify the behavior of GetAllocatableResources endpoint #2761
Pod Resource API: Explicitly clarify the behavior of GetAllocatableResources endpoint #2761
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: swatisehgal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6f81fc1
to
8195d3b
Compare
/cc @fromanirh |
The explanation that GetAllocatableResources can be used to obtain available resources on the node can be misinterpretted as an API that is used to obtain free/unallocated resources on a node. This PR adds additional text to clarify that this API endpoint only returns allocatable resources which are resources exposed to kubelet as defined here: https://kubernetes.io/docs/tasks/administer-cluster/reserve-compute-resources/#node-allocatable. Signed-off-by: Swati Sehgal <[email protected]>
8195d3b
to
6367aaf
Compare
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@swatisehgal: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@swatisehgal: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This change was made as part of the graduation of the feature to Beta here: #2932 so closing this PR. |
The explanation that GetAllocatableResources can be used to obtain available resources
on the node can be misinterpretted as an API that is used to obtain free/unallocated
resources on a node.
This PR adds additional text to clarify that this API endpoint only returns
allocatable resources which are resources exposed to kubelet as defined here:
https://kubernetes.io/docs/tasks/administer-cluster/reserve-compute-resources/#node-allocatable.
Signed-off-by: Swati Sehgal [email protected]