-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing KEPs 2004 and 2030 as they were never implemented #2666
Removing KEPs 2004 and 2030 as they were never implemented #2666
Conversation
These KEPs were effectively replaced by KEP 2433. Since they never even reached alpha, I don't think there's much of a need to leave them in here.
For the record, I'm also fine with leaving these KEPs in and updating them to status "replaced". I took the removal approach here because I think it would be confusing to have 4 networking KEPs with "topology" in the name, but not sure what the standard is for removal. /cc @johnbelamaric |
indeed it can be good to have them for historical context |
I lean towards removal - they are in the permanent history if we need to get them back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These KEPs were effectively replaced by KEP #2433. Since they never even reached alpha, I don't think there's much of a need to leave them in here.
Fixes #2004
Fixes #2030
/sig network
/assign @thockin