-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating from old kep to new template: sig-cluster-lifecycle - kubeadm #2499
Migrating from old kep to new template: sig-cluster-lifecycle - kubeadm #2499
Conversation
58e4c19
to
1fe926c
Compare
1fe926c
to
a80c691
Compare
PR is ready for review. I did not understand test error :
and which tag is missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, thanks.
added a couple of comments.
@@ -1,5 +1,3 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a KEP its just some sequence diagrams that fall under "proposal".
it's also out of date.
i'd say just delete this file.
if someone wants to they can move it to the kubernetes/kubeadm repository under docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also move the file https://github.com/kubernetes/enhancements/blob/a80c69127e965a7c90fbbae70fc2c752c7ae008b/keps/sig-cluster-lifecycle/kubeadm/README.md to the parent sig-cluster-lifecycle folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to the parent folder.
a80c691
to
f380933
Compare
@shekhar-rajak - please regenerate TableOfContents (hack/update-toc.sh) |
Migrating from old kep to new template: sig-cluster-lifecycle - kubeadm Migrating from old kep to new template: sig-cluster-lifecycle - kubeadm README file from kubeadm to parent folder removed README file - not needed
f380933
to
68ab7f8
Compare
Thanks @wojtek-t ! I have updated in new commit. I had to remove a README file because that file do not have any information and no doc which was causing the CI check error. |
/lgtm @neolit123 - can you please take another look (and hopefully approve)? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, shekhar-rajak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to: #2220
Migrating the old KEP files into new format - sig-cluster-lifecycle/kubeadm