Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating from old kep to new template: sig-cluster-lifecycle - kubeadm #2499

Conversation

ghost
Copy link

@ghost ghost commented Feb 12, 2021

Related to: #2220

Migrating the old KEP files into new format - sig-cluster-lifecycle/kubeadm

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 12, 2021
@ghost ghost mentioned this pull request Feb 12, 2021
4 tasks
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 12, 2021
@ghost ghost force-pushed the kep_new_template_sig_cluster_lifecycle_kubeadm branch from 58e4c19 to 1fe926c Compare February 12, 2021 18:36
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2021
@ghost ghost force-pushed the kep_new_template_sig_cluster_lifecycle_kubeadm branch from 1fe926c to a80c691 Compare February 12, 2021 18:41
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 12, 2021
@ghost
Copy link
Author

ghost commented Feb 12, 2021

PR is ready for review. I did not understand test error :

2021/02/12 18:39:32 keps/sig-cluster-lifecycle/kubeadm/2501-kubeadm-phases-to-beta/README.md: missing opening TOC tag

and which tag is missing.

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks.
added a couple of comments.

@@ -1,5 +1,3 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a KEP its just some sequence diagrams that fall under "proposal".
it's also out of date.

i'd say just delete this file.

if someone wants to they can move it to the kubernetes/kubeadm repository under docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to the parent folder.

@ghost ghost force-pushed the kep_new_template_sig_cluster_lifecycle_kubeadm branch from a80c691 to f380933 Compare February 13, 2021 17:28
@wojtek-t
Copy link
Member

@shekhar-rajak - please regenerate TableOfContents (hack/update-toc.sh)

Migrating from old kep to new template: sig-cluster-lifecycle - kubeadm

Migrating from old kep to new template: sig-cluster-lifecycle - kubeadm

README file from kubeadm to parent folder

removed README file - not needed
@ghost ghost force-pushed the kep_new_template_sig_cluster_lifecycle_kubeadm branch from f380933 to 68ab7f8 Compare February 17, 2021 17:54
@ghost
Copy link
Author

ghost commented Feb 17, 2021

Thanks @wojtek-t ! I have updated in new commit. I had to remove a README file because that file do not have any information and no doc which was causing the CI check error.

@wojtek-t
Copy link
Member

/lgtm

@neolit123 - can you please take another look (and hopefully approve)?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2021
@neolit123
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, shekhar-rajak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit abb8d60 into kubernetes:master Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants