Add PRR survey to OIDC Discovery KEP #2363
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign liggitt wojtek-t |
k8s-ci-robot
added
kind/kep
mtaufen
force-pushed
the
said-ga
branch
2 times, most recently
from
7b9a1da
to
8088790
Compare
|
/assign mikedanese |
|
/assign @johnbelamaric |
Add PRR survey as part of preparing to move to GA.
|
|
||
| * **Are there any missing metrics that would be useful to have to improve observability | ||
| of this feature?** | ||
| It would be nice to have usage metrics for this endpoint. We haven't added |
There was a problem hiding this comment.
Is there an existing issue to cover this? I am gathering that the issue is you are serving up a static resource and so any metrics plumbing would have to be in the basic HTTP server in the api server. You don't have any code hit after generating the static data, so you have nowhere to hook in a metric?
If that's the case, perhaps you can at least create an issue and get it on the radar of api machinery, if it's not already.
There was a problem hiding this comment.
Yeah more or less. Just registering a route doesn't seem to get you metrics by default. I could probably add some explicitly in the route handler, but a more transparent solution (with consistent route -> metric name mapping) would be preferable.
Tracking issue: kubernetes/kubernetes#98585
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, mtaufen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Waiting on KEP updates first: kubernetes/enhancements#2363
Add PRR survey as part of preparing to move to GA.