-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding windows privileged containers KEP #2037
Conversation
Welcome @ambguo! |
Hi @ambguo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Can you add a KEP.yaml as well based off of https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/kep.yaml (I apologize that the other sig-windows KEPs don't have this yet, so we did not have any good examples to follow) |
This is for issue #1981 Also note that the dir name is incorrect here it should be 1981-windows-privileged-container-support cc: @kinarashah for review |
…nto windows-privileged-containers
…windows-privileged-containers
Great to see this getting off the ground; looking forward to the day when we can ship Calico as a daemonset on Windows. |
/lgtm Merging this now in a provisional state. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ambguo, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.