Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keps/contribex: Add KEP-1553 (Issue Triage Workflow and Automation) #1554

Merged
merged 1 commit into from
Apr 9, 2020
Merged

keps/contribex: Add KEP-1553 (Issue Triage Workflow and Automation) #1554

merged 1 commit into from
Apr 9, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Feb 15, 2020 •
edited
Loading

Improve issue triage in kubernetes/kubernetes by defining a workflow and automation for contributors.

Signed-off-by: Stephen Augustus [email protected]

Note: This PR uses the modified KEP template being proposed in #1545

/milestone v1.18
/priority important-soon
/kind feature
/sig contributor-experience pm release
cc: @kubernetes/sig-release-admins

ref:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 15, 2020
@justaugustus justaugustus mentioned this pull request Feb 15, 2020
Closed
5 tasks
@justaugustus
Copy link
Member Author

/hold this is WIP

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2020
@justaugustus justaugustus changed the title [WIP] keps/contribex: Add KEP-1553 (Issue Triage Workflow and Automation) keps/contribex: Add KEP-1553 (Issue Triage Workflow and Automation) Feb 15, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2020
@justaugustus justaugustus force-pushed the issue-triage branch 2 times, most recently from 3e42fa6 to fe899e0 Compare February 15, 2020 22:23
@justaugustus
Copy link
Member Author

This is ready for a first-pass review!
/assign @cblecker @nikhita @thockin @mrbobbytables @Phillels

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. sig/pm sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 15, 2020
This was referenced Feb 15, 2020
Closed
Merged
thockin
thockin reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

keps/sig-contributor-experience/1553-issue-triage/README.md Outdated

See [User Stories](#user-stories).

<unresolved>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[<unresolved>]] ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh. <<[UNRESOLVED]>>
ref: https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/617-improve-kep-implementation#1-standardize-an-intra-kep-denotation-for-not-resolved

keps/sig-contributor-experience/1553-issue-triage/README.md Outdated
Here we propose [introducing two new labels](https://github.com/kubernetes/test-infra/pull/16298):

- `needs-triage`
- `triage/accepted-by-sig`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this naming was literally what I suggested. I am just thinking about the people who use this. If they have to type /triage accepted-by-sig - is that too long and obnoxious? You wanted a bikeshed...

triage/accepted
triage/done
triage/ok
triage/ack
triage/complete
triage/d
triage/sig-foo (I know you hate this but it's very clear /triage network => triage/sig-network)
triaged

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with triage/accepted instead.

keps/sig-contributor-experience/1553-issue-triage/README.md
can apply the `triage/accepted-by-sig` label using the following bot command:

```shell
/triage accept
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that is shorter than what I wrote above. I'm going to leave the bikeshed - my gift to you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you have a gift receipt! 🙃

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
@justaugustus
Copy link
Member Author

justaugustus commented Apr 8, 2020 •
edited
Loading

@cblecker @nikhita @mrbobbytables @logicalhan -- Soliciting feedback again...

Current state:

  • propose needs-triage and triage/accepted as labels
  • restrict triage/accepted label application to milestone-maintainers (as there were requests to limit how this label gets applied)
  • remove inactive triage/** labels:
    • triage/duplicate
    • triage/not-reproducible
    • triage/unresolved
  • rename some triage/** labels
    • triage/support --> kind/support
    • triage/needs-information --> lifecycle/needs-information

Let me know what you think! :)
Tagging the @kubernetes/release-team as well.

@mrbobbytables
Copy link
Member

I am good with current state 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, mrbobbytables, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

Lazy consensus timeout achieved!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020
@justaugustus justaugustus modified the milestones: keps-beta, v1.19 Apr 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit fbf96b3 into kubernetes:master Apr 9, 2020
@justaugustus justaugustus mentioned this pull request Apr 10, 2020
Closed
@justaugustus justaugustus added area/enhancements Issues or PRs related to the Enhancements subproject and removed sig/pm labels Apr 19, 2020
@lasomethingsomething
Copy link
Contributor

Hi everyone: I've forked and created a revision of the issue triage guide, and have shared it in the contribex channel for some feedback (received). Some highlights:

Would be great if some of you could give this a look and provide feedback. It currently does not include points made in this KEP, so the next step would be to integrate key portions into the guide. If anyone would like to help with that, please reach out on Slack (I'm @LauriApple).

This was referenced Apr 25, 2020
Closed
Merged
@lasomethingsomething
Copy link
Contributor

Hiya, checking in on the guide revision noted in my previous comment (wondering what the next step might be). Also wondering: is there any recently collected data showing which SIGs are running regular/consistent triage sessions? I know of some that are, but don't have the full picture and am curious if anyone currently does.

@dashpole dashpole mentioned this pull request Jul 28, 2020
Merged
@thockin
Copy link
Member

thockin commented Aug 3, 2020

Hi everyone,

This KEP got merged - did the work get done? Is there any way I can get an update?

@spzala spzala mentioned this pull request Dec 9, 2020
Closed
RomanBednar pushed a commit to RomanBednar/enhancements that referenced this pull request Feb 13, 2024
@openshift-merge-bot
Merge pull request kubernetes#1554 from dhellmann/twie-2024-02-02
84e14fd 
this-week: 2024-02-02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrox1 alejandrox1 alejandrox1 left review comments

@smourapina smourapina smourapina left review comments

@mrbobbytables mrbobbytables mrbobbytables left review comments

@thockin thockin thockin left review comments

@cblecker cblecker cblecker left review comments

@logicalhan logicalhan logicalhan left review comments

@nikhita nikhita Awaiting requested review from nikhita

@parispittman parispittman Awaiting requested review from parispittman

@vllry vllry Awaiting requested review from vllry

Assignees

@cblecker cblecker

@thockin thockin

@mrbobbytables mrbobbytables

@Phillels Phillels

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.