Clarify requirements for permitted x509 extensions #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
RomanBednar
pushed a commit
to RomanBednar/enhancements
that referenced
this pull request
Apr 5, 2024
* USHIFT-2188: introduce microshift API Custom certs Signed-off-by: Evgeny Slutsky <[email protected]> * added kubeconfig for custom Certs section Signed-off-by: Evgeny Slutsky <[email protected]> * added more details regarding kubeconfig generation Signed-off-by: Evgeny Slutsky <[email protected]> * Update according to latest template Signed-off-by: Evgeny Slutsky <[email protected]> * tls-sni-cert-key flag apiserver clearification Signed-off-by: Evgeny Slutsky <[email protected]> * round of review and fixes Signed-off-by: Evgeny Slutsky <[email protected]> * added remark about name not included in the cert Signed-off-by: Evgeny Slutsky <[email protected]> * add Kubeconfig Generation details Signed-off-by: Evgeny Slutsky <[email protected]> * another round of reviews Signed-off-by: Evgeny Slutsky <[email protected]> * added comment about wild-card only certs Signed-off-by: Evgeny Slutsky <[email protected]> * ignore invalid certificate upon service start Signed-off-by: Evgeny Slutsky <[email protected]> * few corrections and clearifications Signed-off-by: Evgeny Slutsky <[email protected]> * added cert san forbidden ip/dns values and few nits Signed-off-by: Evgeny Slutsky <[email protected]> * added reserved missing address Signed-off-by: Evgeny Slutsky <[email protected]> --------- Signed-off-by: Evgeny Slutsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst implementing the recent changes in #1400 in kubernetes/kubernetes, we discovered an ambiguity in the wording for the requirements around x509 extensions for
kubelet-servingspecified CertificateSigningRequests.This patch amends the KEP according to the actual requirements/expectations, based on how the kubelet actually behaves: https://github.com/kubernetes/kubernetes/blob/d90dd93855ab6c3ccda73dfbd3d19c81f56abca5/pkg/kubelet/certificate/kubelet.go#L89-L103
/cc @liggitt
/assign @enj