Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate away from vendor #1162

Merged
merged 1 commit into from
Jul 25, 2019
Merged

migrate away from vendor #1162

merged 1 commit into from
Jul 25, 2019

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Jul 23, 2019

Instead of vendoring the tools this will install the tools when the script is executed and clean up any necessary files when it finishes running, ignoring the newly generated go.mod and go.sum files.

This will allow any tools we want to own to get pulled into this repo and use go mod instead of dep.

For example, there is interest in moving kepval into this repo or at least under the control of kubernetes. I can only assume the same may be true of mdtoc?

Signed-off-by: chuckha [email protected]

/cc @tallclair @nikhita
/assign @justaugustus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/pm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 23, 2019
@justaugustus
Copy link
Member

@chuckha -- can we keep vendor around and add go.mod+go.sum instead?

@chuckha
Copy link
Contributor Author

chuckha commented Jul 23, 2019

it depends on why you want to do that. Can you list out the problems vendor is solving and we can figure out a solution for what you're looking for?

@chuckha chuckha mentioned this pull request Jul 23, 2019
@nikhita
Copy link
Member

nikhita commented Jul 24, 2019

+1 to pruning vendor. From #1163 (comment), I'm guessing there is consensus on removing vendor too?

@chuckha
Copy link
Contributor Author

chuckha commented Jul 24, 2019

@nikhita Yep, that's right, we're going to move away from vendor and if we need to fallback for some reason the option will always be there.

@nikhita
Copy link
Member

nikhita commented Jul 24, 2019

Awesome! This lgtm. :)

@chuckha
Copy link
Contributor Author

chuckha commented Jul 25, 2019

@justaugustus anything else to change here?

@justaugustus
Copy link
Member

Nope, I just hadn't had a chance to do a review sweep of open PRs yet.
Looks great, @chuckha. Thanks again for working on this!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5a5ed91 into kubernetes:master Jul 25, 2019
@justaugustus justaugustus added area/enhancements Issues or PRs related to the Enhancements subproject and removed sig/pm labels Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants