-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate away from vendor #1162
migrate away from vendor #1162
Conversation
@chuckha -- can we keep vendor around and add go.mod+go.sum instead? |
it depends on why you want to do that. Can you list out the problems vendor is solving and we can figure out a solution for what you're looking for? |
+1 to pruning vendor. From #1163 (comment), I'm guessing there is consensus on removing vendor too? |
Signed-off-by: chuckha <[email protected]>
@nikhita Yep, that's right, we're going to move away from vendor and if we need to fallback for some reason the option will always be there. |
Awesome! This lgtm. :) |
@justaugustus anything else to change here? |
Nope, I just hadn't had a chance to do a review sweep of open PRs yet. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Instead of vendoring the tools this will install the tools when the script is executed and clean up any necessary files when it finishes running, ignoring the newly generated go.mod and go.sum files.
This will allow any tools we want to own to get pulled into this repo and use go mod instead of dep.
For example, there is interest in moving kepval into this repo or at least under the control of kubernetes. I can only assume the same may be true of mdtoc?
Signed-off-by: chuckha [email protected]
/cc @tallclair @nikhita
/assign @justaugustus