Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow ups from the RuntimeClass scheduling API / architecture review. Concerns raised in the review:
Topology
is too ambiguous and overloadedThis update addresses those concerns by:
Topology
toScheduling
corev1.NodeSelector
type withmap[string]string
. This makes the merging logic much simpler, so we can mix in the node selector in admission and leave the scheduler untouched. If we find a need for the more complicated node selector logic in the future, we can revisit this decision with an additional field./assign @thockin @dchen1107 @bsalamat @yastij
/sig node
/milestone v1.15
/priority important-soon