Skip to content

Commit

Permalink
address feedback and add comment about e2e tests
Browse files Browse the repository at this point in the history
  • Loading branch information
kannon92 committed Oct 8, 2024
1 parent db42c77 commit d1e8126
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions keps/sig-node/1967-size-memory-backed-volumes/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ To verify the pod available memory scenario, we will verify the
memory backed volume size is equivalent to the pod cgroup memory
or node allocatable memory limit.

We have eviction tests that make sure size backed volumes cannot exceed the size limit.

See [eviction test](https://github.com/kubernetes/kubernetes/blob/b2031b3cb46e946ee72eab7bda87b046db138d62/test/e2e_node/eviction_test.go#L366).

### Graduation Criteria

#### Alpha -> Beta Graduation
Expand Down Expand Up @@ -237,7 +241,7 @@ This does not seem relevant to this feature.
#### How can someone using this feature know that it is working for their instance?

- [x] Other
- Details: An operator can audit for pods whose emptyDir medium is memory and a size limit
- Details: An operator can audit for pods whose emptyDir medium is memory and a size limit
is specified.

#### What are the reasonable SLOs (Service Level Objectives) for the above SLIs?
Expand All @@ -264,9 +268,7 @@ No.

No

#### Will enabling / using this feature result in any new calls to the cloud?

provider?
#### Will enabling / using this feature result in any new calls to the cloud provider?

No

Expand Down

0 comments on commit d1e8126

Please sign in to comment.